Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506725

Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig

From Randy Dunlap <rdunlap@infradead.org>
Newsgroups linux.kernel
Subject Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig
Date 2016-10-23 19:00 +0200
Message-ID <svuhP-3sd-3@gated-at.bofh.it> (permalink)
References <svovL-8f6-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 10/23/16 05:45, vadimp@mellanox.com wrote:
> From: Vadim Pasternak <vadimp@mellanox.com>
> 
> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> hwmon APIs.
> 
> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 65d9b04..1853769 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
>  	tristate "Mellanox platform hotplug driver support"
>  	default n
>  	depends on MLX_PLATFORM
> +	select HWMON
>  	select I2C
>  	---help---
>  	  This driver handles hot-plug events for the power suppliers, power
> 

Hi,
did you test this?  I would expect it to cause a kconfig warning,
something about HWMON having a dependency on HAS_IOMEM.

thanks.
-- 
~Randy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig vadimp@mellanox.com - 2016-10-23 12:50 +0200
  Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox  hotplug driver in Kconfig Darren Hart <dvhart@infradead.org> - 2016-10-23 17:00 +0200
    RE: [patch v1] drivers/platform/x86: select hwmon for Mellanox  hotplug driver in Kconfig Vadim Pasternak <vadimp@mellanox.com> - 2016-10-24 07:40 +0200
  Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox  hotplug driver in Kconfig Randy Dunlap <rdunlap@infradead.org> - 2016-10-23 19:00 +0200
    RE: [patch v1] drivers/platform/x86: select hwmon for Mellanox  hotplug driver in Kconfig Vadim Pasternak <vadimp@mellanox.com> - 2016-10-24 08:40 +0200
    RE: [patch v1] drivers/platform/x86: select hwmon for Mellanox  hotplug driver in Kconfig Vadim Pasternak <vadimp@mellanox.com> - 2016-10-24 19:20 +0200
      Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox  hotplug driver in Kconfig Randy Dunlap <rdunlap@infradead.org> - 2016-10-24 19:20 +0200
        Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox  hotplug driver in Kconfig Darren Hart <dvhart@infradead.org> - 2016-10-24 20:20 +0200
  Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox  hotplug driver in Kconfig Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-24 11:00 +0200

csiph-web