Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1506699

Re: [PATCH 2/2] kdb: Call vkdb_printf() from vprintk_default() only when wanted

From Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] kdb: Call vkdb_printf() from vprintk_default() only when wanted
Date 2016-10-23 15:30 +0200
Message-ID <svr0B-1tk-7@gated-at.bofh.it> (permalink)
References <suHAu-5DG-9@gated-at.bofh.it> <suHAv-5DG-43@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On (10/21/16 14:50), Petr Mladek wrote:
[..]
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index d5e397315473..db73e33811e7 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -1941,7 +1941,9 @@ int vprintk_default(const char *fmt, va_list args)
>  	int r;
>  
>  #ifdef CONFIG_KGDB_KDB
> -	if (unlikely(kdb_trap_printk)) {
> +	/* Allow to pass printk() to kdb but avoid a recursion. */
> +	if (unlikely(kdb_trap_printk &&
> +		     kdb_printf_cpu != smp_processor_id())) {
					^^^^^
		aren't we are in preemptible here?

	-ss

>  		r = vkdb_printf(KDB_MSGSRC_PRINTK, fmt, args);
>  		return r;

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] kdb: Call vkdb_printf() from vprintk_default() only when wanted Petr Mladek <pmladek@suse.com> - 2016-10-21 15:00 +0200
  Re: [PATCH 2/2] kdb: Call vkdb_printf() from vprintk_default() only  when wanted Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-23 15:30 +0200

csiph-web