Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1506686

Re: [v7, 1/3] nand: pl353: Add basic driver for arm pl353 smc nand interface

From punnaiah choudary kalluri <punnaia@xilinx.com>
Newsgroups linux.kernel
Subject Re: [v7, 1/3] nand: pl353: Add basic driver for arm pl353 smc nand interface
Date 2016-10-23 14:10 +0200
Message-ID <svpLb-JT-7@gated-at.bofh.it> (permalink)
References <pBuc2-Y9-7@gated-at.bofh.it> <suOLD-2ds-11@gated-at.bofh.it> <suPRo-2Qf-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Boris and Jason,

 I am doing rework on these patches to accommodate recent changes with
 respect to ooblayout. Also some of the comments that i have received
from Boris as part of the arasan nand controller upstream patches will
apply to this driver. So, i will be releasing the next set of patches for this
driver soon and request your time for reviewing those patches.

for now, please ignore these patches.

Regards,
Punnaiah

On Sat, Oct 22, 2016 at 3:16 AM, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
> On Fri, 21 Oct 2016 14:33:22 -0600
> Jason Gunthorpe <jgunthorpe@obsidianresearch.com> wrote:
>
>> On Mon, Jun 08, 2015 at 11:38:36PM +0530, Punnaiah Choudary Kalluri wrote:
>> > Add driver for arm pl353 static memory controller nand interface with
>> > HW ECC support. This controller is used in xilinx zynq soc for interfacing
>> > the nand flash memory.
>> >
>> > Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
>> > Changes in v7:
>> >  - Currently not implemented the memclk rate adjustments. I will
>> >    look into this later and once the basic driver is accepted.
>> >  - Fixed GPL licence ident
>> > Changes in v6:
>> >  - Fixed the checkpatch.pl reported warnings
>> >  - Using the address cycles information from the onfi param page
>> >    earlier it is hardcoded to 5 in driver
>> > Changes in v5:
>> >  - Configure the nand timing parameters as per the onfi spec
>> > Changes in v4:
>> >  - Updated the driver to sync with pl353_smc driver APIs
>> > Changes in v3:
>> >  - implemented the proper error codes
>> >  - further breakdown this patch to multiple sets
>> >  - added the controller and driver details to Documentation section
>> >  - updated the licenece to GPLv2
>> >  - reorganized the pl353_nand_ecc_init function
>> > Changes in v2:
>> >  - use "depends on" rather than "select" option in kconfig
>> >  - remove unused variable parts
>> >  - remove dummy helper and use writel_relaxed directly
>>
>> What is the status of getting this driver merged? I am interested in
>> this driver and can provide some help if there are still TODO items.
>
> I'll try to review it next week.
>
>>
>> At the very least I will test it, is there something newer than v7 out
>> there?
>>
>> Regards,
>> Jason
>>
>> ______________________________________________________
>> Linux MTD discussion mailing list
>> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [v7, 1/3] nand: pl353: Add basic driver for arm pl353 smc nand  interface Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-10-21 22:40 +0200
  Re: [v7, 1/3] nand: pl353: Add basic driver for arm pl353 smc nand  interface Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-21 23:50 +0200
    Re: [v7, 1/3] nand: pl353: Add basic driver for arm pl353 smc nand interface punnaiah choudary kalluri <punnaia@xilinx.com> - 2016-10-23 14:10 +0200
      Re: [v7, 1/3] nand: pl353: Add basic driver for arm pl353 smc nand  interface Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-24 14:30 +0200
      Re: [v7, 1/3] nand: pl353: Add basic driver for arm pl353 smc nand  interface Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-10-25 01:10 +0200
        Re: [v7, 1/3] nand: pl353: Add basic driver for arm pl353 smc nand  interface Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-10-25 06:50 +0200

csiph-web