Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion

From	Lukasz Majewski <l.majewski@majess.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion
Date	2016-10-23 08:50 +0200
Message-ID	<svkLv-5TP-1@gated-at.bofh.it> (permalink)
References	(5 earlier) <srHdD-7LS-7@gated-at.bofh.it> <sui93-5JM-9@gated-at.bofh.it> <suutA-5mC-23@gated-at.bofh.it> <sv0Wt-1Bd-9@gated-at.bofh.it> <sv3hD-3en-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Boris,

> > 
> > Could you be more specific here? 
> > 
> > As I mentioned before, the problem is not with the lack of
> > "atomic" API.  
> 
> Below is a quick and dirty I made on top of this patch to show you how
> atomic update can be implemented in this driver. 

Thank you for example patch.

I will implement the ->apply() callback and post patches very soon :-).

I had two issues with the ->apply() implementation:

- Do my work on top of this patch (https://lkml.org/lkml/2016/10/7/454
  as you did) to avoid rewriting work already done.

- In the example ->apply() implementation for rockchip
  (https://patchwork.kernel.org/patch/7228221/) the ->config() callback
  was not removed when ->apply() was implemented. I was confused with
  such approach, but as you explained in this mail, the solely ->apply()
  is enough.

> It's not tested, and
> probably not working, but it should give you a better idea of what is
> expected.

Thanks for explanation,

Łukasz Majewski

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion Lukasz Majewski <l.majewski@majess.pl> - 2016-10-13 08:00 +0200
  Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion Lukasz Majewski <l.majewski@majess.pl> - 2016-10-20 11:50 +0200
    Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion Stefan Agner <stefan@agner.ch> - 2016-10-21 01:00 +0200
      Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion Lukasz Majewski <l.majewski@majess.pl> - 2016-10-22 11:40 +0200
        Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-22 13:00 +0200
        Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-22 14:10 +0200
          Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion Lukasz Majewski <l.majewski@majess.pl> - 2016-10-23 08:50 +0200

csiph-web