Re: [PATCH v2 4/4] cpufreq: pxa: convert to clock API

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/4] cpufreq: pxa: convert to clock API
Date	2016-10-22 23:40 +0200
Message-ID	<svcbf-kz-1@gated-at.bofh.it> (permalink)
References	<ssDrj-45V-5@gated-at.bofh.it> <ssDrj-45V-11@gated-at.bofh.it> <stB45-13O-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Viresh Kumar <viresh.kumar@linaro.org> writes:

> On 15-10-16, 21:57, Robert Jarzmik wrote:
>> As the clock settings have been introduced into the clock pxa drivers,
>> which are now available to change the CPU clock by themselves, remove
>> the clock handling from this driver, and rely on pxa clock drivers.
>> 
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> ---
>> Since v1: added !OF Kconfig dependency
>> ---
>>  drivers/cpufreq/Kconfig.arm      |   2 +-
>>  drivers/cpufreq/pxa2xx-cpufreq.c | 191 ++++++++-------------------------------
>>  2 files changed, 40 insertions(+), 153 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Okay, after some more testing, I'd like to remove the !OF for next iteration.
The reason is that I have a usecase where I have a single kernel image with
devictree support (ie CONFIG_OF=y), but with support for both devicetree and
legacy platforms. In this case, a platform such as lubbock can boot :
 - with devicetree
 - with legacy arch/arm/mach-pxa/lubbock.c

In this kernel, the !OF Kconfig prevents the legacy version from working, as
pxa2xx-cpufreq is descarded even if it is needed in the legacy version.

Therefore, I'd like to respin without this !OF.

Cheers.

-- 
Robert

Thread

[PATCH v2 4/4] cpufreq: pxa: convert to clock API Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-15 22:10 +0200
  Re: [PATCH v2 4/4] cpufreq: pxa: convert to clock API Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-18 13:50 +0200
    Re: [PATCH v2 4/4] cpufreq: pxa: convert to clock API Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-22 23:40 +0200
      Re: [PATCH v2 4/4] cpufreq: pxa: convert to clock API Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-24 05:40 +0200

csiph-web