Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506597

[PATCH 6/6] IA64-sn2_smp: Combine two seq_printf() calls into one call in sn2_ptc_seq_show()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 22 Oct 2016 21:19:03 +0200

Some data were printed into a sequence by two separate function calls.
Print the same data by a single function call instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/ia64/sn/kernel/sn2/sn2_smp.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/arch/ia64/sn/kernel/sn2/sn2_smp.c b/arch/ia64/sn/kernel/sn2/sn2_smp.c
index c98dc96..1beac3c 100644
--- a/arch/ia64/sn/kernel/sn2/sn2_smp.c
+++ b/arch/ia64/sn/kernel/sn2/sn2_smp.c
@@ -494,12 +494,11 @@ static int sn2_ptc_seq_show(struct seq_file *file, void *data)
 	int cpu;
 
 	cpu = *(loff_t *) data;
-
-	if (!cpu) {
+	if (!cpu)
 		seq_printf(file,
-			   "# cpu ptc_l newrid ptc_flushes nodes_flushed deadlocks lock_nsec shub_nsec shub_nsec_max not_my_mm deadlock2 ipi_fluches ipi_nsec\n");
-		seq_printf(file, "# ptctest %d, flushopt %d\n", sn2_ptctest, sn2_flush_opt);
-	}
+			   "# cpu ptc_l newrid ptc_flushes nodes_flushed deadlocks lock_nsec shub_nsec shub_nsec_max not_my_mm deadlock2 ipi_fluches ipi_nsec\n"
+			   "# ptctest %d, flushopt %d\n",
+			   sn2_ptctest, sn2_flush_opt);
 
 	if (cpu < nr_cpu_ids && cpu_online(cpu)) {
 		stat = &per_cpu(ptcstats, cpu);
-- 
2.10.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] IA64: Fine-tuning for five function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-22 22:00 +0200
  [PATCH 4/6] IA64-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-22 22:00 +0200
  [PATCH 6/6] IA64-sn2_smp: Combine two seq_printf() calls into one  call in sn2_ptc_seq_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-22 22:00 +0200
    Re: [PATCH 6/6] IA64-sn2_smp: Combine two seq_printf() calls into  one call in sn2_ptc_seq_show() Joe Perches <joe@perches.com> - 2016-10-22 22:10 +0200
      Re: [PATCH 6/6] IA64-sn2_smp: Combine two seq_printf() calls into one  call in sn2_ptc_seq_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-22 22:50 +0200
        Re: [PATCH 6/6] IA64-sn2_smp: Combine two seq_printf() calls into  one call in sn2_ptc_seq_show() Julia Lawall <julia.lawall@lip6.fr> - 2016-10-23 07:50 +0200
          Re: IA64-sn2_smp: Combine two seq_printf() calls into one call in  sn2_ptc_seq_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-23 08:40 +0200
  [PATCH 3/6] IA64-simserial: Use seq_puts() in rs_proc_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-22 22:00 +0200

csiph-web