Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1507909

Re: [RFC 1/8] mm: Define coherent device memory node

Show all headers | View raw

On 10/24/2016 10:39 PM, Dave Hansen wrote:
>> +#ifdef CONFIG_COHERENT_DEVICE
>> > +#define node_cdm(nid)          (NODE_DATA(nid)->coherent_device)
>> > +#define set_cdm_isolation(nid) (node_cdm(nid) = 1)
>> > +#define clr_cdm_isolation(nid) (node_cdm(nid) = 0)
>> > +#define isolated_cdm_node(nid) (node_cdm(nid) == 1)
>> > +#else
>> > +#define set_cdm_isolation(nid) ()
>> > +#define clr_cdm_isolation(nid) ()
>> > +#define isolated_cdm_node(nid) (0)
>> > +#endif
> FWIW, I think adding all this "cdm" gunk in the names is probably a bad
> thing.
> 
> I can think of other memory types that are coherent, but
> non-device-based that might want behavior like this.

Hmm, I was not aware about non-device-based coherent memory. Could you
please name some of them ? If thats the case we need to change CDM to
some thing which can accommodate both device and non device based
coherent memory. May be like "Differentiated/special coherent memory".
But it needs to communicate that its not system RAM. Thats the idea.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 1/8] mm: Define coherent device memory node Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2016-10-24 06:40 +0200
  Re: [RFC 1/8] mm: Define coherent device memory node Dave Hansen <dave.hansen@intel.com> - 2016-10-24 19:10 +0200
    Re: [RFC 1/8] mm: Define coherent device memory node Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2016-10-25 03:30 +0200
      Re: [RFC 1/8] mm: Define coherent device memory node Dave Hansen <dave.hansen@intel.com> - 2016-10-25 17:50 +0200

csiph-web