Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1507838

Re: [PATCH v1] Input: synaptics-rmi4 - allow number of PDT pages to be specified

Show all headers | View raw

On Mon, Oct 24, 2016 at 05:03:30PM -0700, Andrew Duggan wrote:
> On 10/24/2016 04:39 PM, Dmitry Torokhov wrote:
> >On Mon, Oct 24, 2016 at 11:55:22PM +0100, Nick Dyer wrote:
> >>We have encountered some RMI4 firmwares where there are blank pages in between
> >>PDT pages which contain functions. Add a device tree property which can be set
> >>to force reading the first N pages.
> >Cann we get updated firmware instead? This seems like violation of RMI
> >protocol. Or, if it is allowed by the protocol, can we avoid DT
> >parameter and keep scanning until the end?
> 
> It is a violation of the RMI4 spec and we found at least one other
> device with misconfigured firmware, so this problem extends beyond
> just a single device. We are adding steps to our verification
> process to make sure we catch these misconfigurations in the future.
> But, I'm not sure we can guarantee that a device with this issue
> didn't go into production.
> 
> I like Guenter's suggestion of requiring two empty pages to stop
> scanning. If we did that for all devices it would add one extra read
> to the PDT scan, but we would avoid us having to maintain a list of
> devices or set additional parameters.

OK, if that fixes broken firmware then that's what I would prefer.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] Input: synaptics-rmi4 - allow number of PDT pages to be specified Nick Dyer <nick@shmanahar.org> - 2016-10-25 01:00 +0200
  Re: [PATCH v1] Input: synaptics-rmi4 - allow number of PDT pages to  be specified Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-25 01:40 +0200
    Re: [PATCH v1] Input: synaptics-rmi4 - allow number of PDT pages to  be specified Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-25 02:10 +0200
    Re: [PATCH v1] Input: synaptics-rmi4 - allow number of PDT pages to  be specified Andrew Duggan <aduggan@synaptics.com> - 2016-10-25 02:20 +0200

csiph-web