Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1507833

Re: [PATCH v2] shmem: avoid maybe-uninitialized warning

Show all headers | View raw

On Mon, Oct 24, 2016 at 10:57:09PM +0200, Arnd Bergmann wrote:
> After enabling -Wmaybe-uninitialized warnings, we get a false-postive
> warning for shmem:
> 
> mm/shmem.c: In function ‘shmem_getpage_gfp’:
> include/linux/spinlock.h:332:21: error: ‘info’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> This can be easily avoided, since the correct 'info' pointer is known
> at the time we first enter the function, so we can simply move the
> initialization up. Moving it before the first label avoids the
> warning and lets us remove two later initializations.
> 
> Note that the function is so hard to read that it not only confuses
> the compiler, but also most readers and without this patch it could\
> easily break if one of the 'goto's changed.
> 
> Link: https://www.spinics.net/lists/kernel/msg2368133.html
> Acked-by: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] shmem: avoid maybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2016-10-24 23:00 +0200
  Re: [PATCH v2] shmem: avoid maybe-uninitialized warning "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-10-25 01:50 +0200
  Re: [PATCH v2] shmem: avoid maybe-uninitialized warning Vlastimil Babka <vbabka@suse.cz> - 2016-10-25 11:00 +0200

csiph-web