Re: [PATCH] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning
Date	2016-10-24 22:50 +0200
Message-ID	<svUlY-4eX-11@gated-at.bofh.it> (permalink)
References	<svPcB-SB-9@gated-at.bofh.it> <svQV4-26N-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday, October 24, 2016 8:06:42 PM CEST Leon Romanovsky wrote:
> 
> Acked-by: Leon Romanovsky <leonro@mellanox.com>

Thanks!

> >  drivers/infiniband/hw/mlx5/mr.c | 39 +++++++++++++++++++++------------------
> >  1 file changed, 21 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> > index d4ad672b905b..88d8d292677b 100644
> > --- a/drivers/infiniband/hw/mlx5/mr.c
> > +++ b/drivers/infiniband/hw/mlx5/mr.c
> > @@ -815,29 +815,33 @@ static void prep_umr_unreg_wqe(struct mlx5_ib_dev *dev,
> >       umrwr->mkey = key;
> >  }
> >
> > -static struct ib_umem *mr_umem_get(struct ib_pd *pd, u64 start, u64 length,
> > -                                int access_flags, int *npages,
> > -                                int *page_shift, int *ncont, int *order)
> > +static int mr_umem_get(struct ib_pd *pd, u64 start, u64 length,
> > +                    int access_flags, struct ib_umem ** umem,
> 
> I wonder if checkpatch does differentiate between "struct ib_umem ** umem"
> and "struct ib_umem **umem". According to coding style, the second is preferable.

It was unintended, I'll send a v2 patch in a minute.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2016-10-24 17:20 +0200
  Re: [PATCH] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning Leon Romanovsky <leonro@mellanox.com> - 2016-10-24 19:10 +0200
    Re: [PATCH] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2016-10-24 22:50 +0200

csiph-web