Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1507686

Re: [PATCH] can: fix warning in bcm_connect/proc_register

Show all headers | View raw

On Mon, Oct 24, 2016 at 1:10 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Mon, Oct 24, 2016 at 12:11 PM, Oliver Hartkopp
> <socketcan@hartkopp.net> wrote:
>>         if (proc_dir) {
>>                 /* unique socket address as filename */
>>                 sprintf(bo->procname, "%lu", sock_i_ino(sk));
>>                 bo->bcm_proc_read = proc_create_data(bo->procname, 0644,
>>                                                      proc_dir,
>>                                                      &bcm_proc_fops, sk);
>> +               if (!bo->bcm_proc_read) {
>> +                       ret = -ENOMEM;
>> +                       goto fail;
>> +               }
>
> Well, I meant we need to call proc_create_data() once per socket,
> so we need a check before proc_create_data() too.

Hmm, bo->bound should guarantee it, so never mind, your patch
looks fine.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] can: fix warning in bcm_connect/proc_register Oliver Hartkopp <socketcan@hartkopp.net> - 2016-10-24 21:20 +0200
  Re: [PATCH] can: fix warning in bcm_connect/proc_register Cong Wang <xiyou.wangcong@gmail.com> - 2016-10-24 22:20 +0200
    Re: [PATCH] can: fix warning in bcm_connect/proc_register Andrey Konovalov <andreyknvl@google.com> - 2016-10-25 14:20 +0200
  Re: [PATCH] can: fix warning in bcm_connect/proc_register Cong Wang <xiyou.wangcong@gmail.com> - 2016-10-24 22:20 +0200

csiph-web