Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1507636

Re: [PATCH v2 1/2] kthread: allocate kthread structure using kmalloc

Path csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Roman Penyaev <roman.penyaev@profitbricks.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/2] kthread: allocate kthread structure using kmalloc
Date Mon, 24 Oct 2016 21:20:01 +0200
Message-ID <svSWR-3rd-5@gated-at.bofh.it> (permalink)
References <svPYZ-1uD-5@gated-at.bofh.it> <svQBH-1Ks-5@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=profitbricks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=m8E3wlB7EXqRn3eP62co1FPRQw/fyyQBDfCDUoe1M4U=; b=hMM/M1sT64PwR5qxqI08cfBM2M+pGGXq+EsBjU0iB20G5jV1lbyRyNTplcdyu17DcA Pwo3qiho1B53DoFZkfI8E/2IIYsZEyE1Po3YssEXZhWfAO2fUq/iExUN4BsrHVTGpOCV N05s+8oEDdXyjK0z8u0HOwG1H19zVbsGDqEdXCT4V5fS0m7iPoq7RyrQMFTvvcZGlOio a489bz1sG9xT2InIrhuvhaZ5I2wPLyJGNeNxVqxqNVELgVjyTLpbaNFmBuAEyFR5ws7n RRHDLJssyqFKbu/ks+hDf6wziKK0k5iGCjptIExQm5YRymukaJJdG6LWkcb6jYJWJh4B nayg==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=m8E3wlB7EXqRn3eP62co1FPRQw/fyyQBDfCDUoe1M4U=; b=WfIulF8AKTuGGeZezrnk2m5WT9HQrt68aqh/h1LXA9Swk11/RP3DQXMvGS+Qu1HSWG 8FLcuNuTjI7Odu42OXGG1fWSdB9Glrno7NEp6bHF2p+dgwHuRmUYHS0vCyC3bpzeDSzJ tyHN4IxWQEnVvaGS7KpalAExQnr20WAd6t8E8ltswwekjM6OXpVnQTyb35LqXDO83+Ba 7/Ml2Dithl1/fR7ABB4LpcFiERQw278MXueMuO0JLdKKHCHQIJhc9MtUJPjuoNoKHT5j iFL6WnlJrTR3Xcd2Dy0/ulZeXRYxzuOLJ+UcYoMzmcB/fMj+26q2s5OWV50LifHIBuc6 FSbQ==
X-Gm-Message-State ABUngvdGykJxWZEH2kHuNejtvd+KgljNoiDJzNfF81Qv3H1GdSf3TLWhp7uZAz66GGpiX+dQJCLHPxYSYfRN9cmh
X-Received by 10.36.117.136 with SMTP id y130mr3491711itc.0.1477336226481; Mon, 24 Oct 2016 12:10:26 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 21
Organization linux.* mail to news gateway
X-Original-Cc Andy Lutomirski <luto@kernel.org>, Oleg Nesterov <oleg@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org
X-Original-Date Mon, 24 Oct 2016 21:10:06 +0200
X-Original-Message-ID <CAJrWOzB9NmnVRQ7UUCLw+WcA+w50SuG-2UFCczKBjJe4wHj1jg@mail.gmail.com>
X-Original-References <20161024160814.3126-1-roman.penyaev@profitbricks.com> <20161024164218.GT3102@twins.programming.kicks-ass.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1507636

Show key headers only | View raw


On Mon, Oct 24, 2016 at 6:42 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, Oct 24, 2016 at 06:08:13PM +0200, Roman Pen wrote:
>> This patch avoids allocation of kthread structure on a stack, and simply
>> uses kmalloc.  Allocation on a stack became a huge problem (with memory
>> corruption and all other not nice consequences) after the commit 2deb4be28
>
> 2deb4be28077 ("x86/dumpstack: When OOPSing, rewind the stack before do_exit()")
>
> Is the normal quoting style.
>
> .gitconfig:
>
> [core]
>         abbrev = 12
> [alias]
>         one = show -s --pretty='format:%h (\"%s\")'

Nice tip. Thanks.

--
Roman

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 1/2] kthread: allocate kthread structure using kmalloc Roman Pen <roman.penyaev@profitbricks.com> - 2016-10-24 18:10 +0200
  Re: [PATCH v2 1/2] kthread: allocate kthread structure using kmalloc Peter Zijlstra <peterz@infradead.org> - 2016-10-24 18:50 +0200
    Re: [PATCH v2 1/2] kthread: allocate kthread structure using kmalloc Roman Penyaev <roman.penyaev@profitbricks.com> - 2016-10-24 21:20 +0200
  Re: [PATCH v2 1/2] kthread: allocate kthread structure using kmalloc Andy Lutomirski <luto@amacapital.net> - 2016-10-24 19:10 +0200
    Re: [PATCH v2 1/2] kthread: allocate kthread structure using kmalloc Roman Penyaev <roman.penyaev@profitbricks.com> - 2016-10-24 21:40 +0200

csiph-web