Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1507582
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Stable 4.4 - NEEDS REVIEW - 1/3] mm: workingset: fix crash in shadow node shrinker caused by replace_page_cache_page() |
| Date | 2016-10-24 21:00 +0200 |
| Message-ID | <svSDv-34S-3@gated-at.bofh.it> (permalink) |
| References | <svPmh-ZI-3@gated-at.bofh.it> <svPmi-ZI-23@gated-at.bofh.it> <svSDv-34S-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon 24-10-16 14:52:23, Johannes Weiner wrote:
> On Mon, Oct 24, 2016 at 05:26:03PM +0200, Michal Hocko wrote:
[...]
> > diff --git a/include/linux/swap.h b/include/linux/swap.h
> > index 7ba7dccaf0e7..b28de19aadbf 100644
> > --- a/include/linux/swap.h
> > +++ b/include/linux/swap.h
> > @@ -266,6 +266,7 @@ static inline void workingset_node_pages_inc(struct radix_tree_node *node)
> >
> > static inline void workingset_node_pages_dec(struct radix_tree_node *node)
> > {
> > + VM_BUG_ON(!workingset_node_pages(node));
> > node->count--;
> > }
>
> We should also pull 21f54ddae449 ("Using BUG_ON() as an assert() is
> _never_ acceptable") into stable on top of this patch to replace the
> BUG_ONs with warnings.
>
> Otherwise this looks good to me.
OK, I have put that one on top and after the review will post it in one
series. Thanks for the review Johannes!
--
Michal Hocko
SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[Stable 4.4 - NEEDS REVIEW - 0/3] mm: working set fixes Michal Hocko <mhocko@kernel.org> - 2016-10-24 17:30 +0200
[Stable 4.4 - NEEDS REVIEW - 2/3] mm: filemap: don't plant shadow entries without radix tree node Michal Hocko <mhocko@kernel.org> - 2016-10-24 17:30 +0200
Re: [Stable 4.4 - NEEDS REVIEW - 2/3] mm: filemap: don't plant shadow entries without radix tree node Johannes Weiner <hannes@cmpxchg.org> - 2016-10-24 21:00 +0200
Re: [Stable 4.4 - NEEDS REVIEW - 2/3] mm: filemap: don't plant shadow entries without radix tree node Michal Hocko <mhocko@kernel.org> - 2016-10-24 21:20 +0200
[Stable 4.4 - NEEDS REVIEW - 3/3] mm: filemap: fix mapping->nrpages double accounting in fuse Michal Hocko <mhocko@kernel.org> - 2016-10-24 17:30 +0200
Re: [Stable 4.4 - NEEDS REVIEW - 3/3] mm: filemap: fix mapping->nrpages double accounting in fuse Johannes Weiner <hannes@cmpxchg.org> - 2016-10-24 21:00 +0200
[Stable 4.4 - NEEDS REVIEW - 1/3] mm: workingset: fix crash in shadow node shrinker caused by replace_page_cache_page() Michal Hocko <mhocko@kernel.org> - 2016-10-24 17:30 +0200
Re: [Stable 4.4 - NEEDS REVIEW - 1/3] mm: workingset: fix crash in shadow node shrinker caused by replace_page_cache_page() Michal Hocko <mhocko@kernel.org> - 2016-10-24 21:00 +0200
Re: [Stable 4.4 - NEEDS REVIEW - 1/3] mm: workingset: fix crash in shadow node shrinker caused by replace_page_cache_page() Johannes Weiner <hannes@cmpxchg.org> - 2016-10-24 21:00 +0200
csiph-web