Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1507543

Re: [net-next PATCH RFC 01/26] swiotlb: Drop unused function swiotlb_map_sg

Show all headers | View raw

On Mon, Oct 24, 2016 at 08:04:31AM -0400, Alexander Duyck wrote:
> There are no users for swiotlb_map_sg so we might as well just drop it.
> 
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thought I swear I saw a familiar patch by Christopher Hellwig at some point..
but maybe that patchset had been dropped.

> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> ---
>  include/linux/swiotlb.h |    4 ----
>  lib/swiotlb.c           |    8 --------
>  2 files changed, 12 deletions(-)
> 
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> index 5f81f8a..e237b6f 100644
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -72,10 +72,6 @@ extern void swiotlb_unmap_page(struct device *hwdev, dma_addr_t dev_addr,
>  			       size_t size, enum dma_data_direction dir,
>  			       unsigned long attrs);
>  
> -extern int
> -swiotlb_map_sg(struct device *hwdev, struct scatterlist *sg, int nents,
> -	       enum dma_data_direction dir);
> -
>  extern void
>  swiotlb_unmap_sg(struct device *hwdev, struct scatterlist *sg, int nents,
>  		 enum dma_data_direction dir);
> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
> index 22e13a0..47aad37 100644
> --- a/lib/swiotlb.c
> +++ b/lib/swiotlb.c
> @@ -910,14 +910,6 @@ void swiotlb_unmap_page(struct device *hwdev, dma_addr_t dev_addr,
>  }
>  EXPORT_SYMBOL(swiotlb_map_sg_attrs);
>  
> -int
> -swiotlb_map_sg(struct device *hwdev, struct scatterlist *sgl, int nelems,
> -	       enum dma_data_direction dir)
> -{
> -	return swiotlb_map_sg_attrs(hwdev, sgl, nelems, dir, 0);
> -}
> -EXPORT_SYMBOL(swiotlb_map_sg);
> -
>  /*
>   * Unmap a set of streaming mode DMA translations.  Again, cpu read rules
>   * concerning calls here are the same as for swiotlb_unmap_page() above.
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[net-next PATCH RFC 00/26] Add support for DMA writable pages being  writable by the network stack Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:10 +0200
  [net-next PATCH RFC 26/26] igb: Revert "igb: Revert support for  build_skb in igb" Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:10 +0200
  [net-next PATCH RFC 07/26] arch/c6x: Add option to skip sync on DMA  map and unmap Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:10 +0200
  [net-next PATCH RFC 10/26] arch/m68k: Add option to skip DMA sync  as a part of mapping Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:10 +0200
  [net-next PATCH RFC 13/26] arch/mips: Add option to skip DMA sync  as a part of map and unmap Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:10 +0200
  [net-next PATCH RFC 12/26] arch/microblaze: Add option to skip DMA  sync as a part of map and unmap Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:10 +0200
  Re: [net-next PATCH RFC 01/26] swiotlb: Drop unused function  swiotlb_map_sg Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-10-24 20:20 +0200
  [net-next PATCH RFC 02/26] swiotlb: Add support for  DMA_ATTR_SKIP_CPU_SYNC Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:20 +0200
  [net-next PATCH RFC 01/26] swiotlb: Drop unused function  swiotlb_map_sg Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:20 +0200
  [net-next PATCH RFC 09/26] arch/hexagon: Add option to skip DMA  sync as a part of mapping Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:20 +0200
  [net-next PATCH RFC 08/26] arch/frv: Add option to skip sync on DMA  map Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:20 +0200
  [net-next PATCH RFC 15/26] arch/openrisc: Add option to skip DMA  sync as a part of mapping Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:20 +0200
  [net-next PATCH RFC 03/26] arch/arc: Add option to skip sync on DMA  mapping Alexander Duyck <alexander.h.duyck@intel.com> - 2016-10-24 20:20 +0200

csiph-web