Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1507493
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/6] sparc64: Add ATU (new IOMMU) support |
| Date | 2016-10-24 19:50 +0200 |
| Message-ID | <svRxM-2mA-13@gated-at.bofh.it> (permalink) |
| References | <sqNl7-4wk-3@gated-at.bofh.it> <sqNl8-4wk-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Tushar Dave <tushar.n.dave@oracle.com>
Date: Mon, 10 Oct 2016 11:12:03 -0700
> + /* calculate size of IOTSB */
> + table_size = (atu->size / IO_PAGE_SIZE) * 8;
> + table = kzalloc(table_size, GFP_KERNEL);
> + if (!table) {
> + err = -ENOMEM;
> + goto table_failed;
> + }
> + table = (void *)IO_PAGE_ALIGN((u64)table);
If you use the page allocator directly you can avoid all of these
funny alignment calculations.
> @@ -931,8 +1046,10 @@ static int pci_sun4v_probe(struct platform_device *op)
> struct pci_pbm_info *pbm;
> struct device_node *dp;
> struct iommu *iommu;
> + struct atu *atu;
> u32 devhandle;
> int i, err = -ENODEV;
> + static bool hv_atu = 1;
Please use true/false with boolean variables.
> + hv_atu = 0;
Likewise.
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH 2/6] sparc64: Add ATU (new IOMMU) support David Miller <davem@davemloft.net> - 2016-10-24 19:50 +0200 Re: [PATCH 2/6] sparc64: Add ATU (new IOMMU) support tndave <tushar.n.dave@oracle.com> - 2016-10-24 22:50 +0200
csiph-web