Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1507481

Re: [RFC PATCH 1/2] ASoC: core: Print one-time messages if missing resources when binding DAIs

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Oct 19, 2016 at 02:21:05PM -0300, Javier Martinez Canillas wrote:
> If snd_soc_find_dai() doesn't find a DAI in soc_bind_dai_link(), a
> error message is printed and an -EPROBE_DEFER errno code returned to
> the caller.

> But since many probe retries can happen before a resource is available,
> the printed messages can spam the kernel log buffer and slow the boot.

> The information is useful to know that a dependency was not meet and a
> defer happened, but isn't necessary to print it on each probe deferral.

This then turns any subsequent failure into a silent one which isn't
great for diagnostics.  It'd be better to look into trying to avoid the
retries in the first place, Raphael's dependency graph stuff looks very
promising here.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/2] ASoC: core: Print one-time messages if missing resources when binding DAIs Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-19 19:30 +0200
  Re: [RFC PATCH 1/2] ASoC: core: Print one-time messages if missing  resources when binding DAIs Mark Brown <broonie@kernel.org> - 2016-10-24 19:30 +0200
    Re: [RFC PATCH 1/2] ASoC: core: Print one-time messages if missing  resources when binding DAIs Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-24 20:40 +0200

csiph-web