Re: [PATCH] drm/arm: mark symbols static where possible

From	liviu.dudau@arm.com
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/arm: mark symbols static where possible
Date	2016-10-24 20:00 +0200
Message-ID	<svRHr-2q3-13@gated-at.bofh.it> (permalink)
References	<sv0D7-1uS-1@gated-at.bofh.it> <svKwh-6el-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 24, 2016 at 12:18:37PM +0200, Arnd Bergmann wrote:
> On Saturday, October 22, 2016 5:13:01 PM CEST Baoyou Xie wrote:
> > We get 2 warnings when building kernel with W=1:
> > drivers/gpu/drm/arm/malidp_planes.c:49:25: warning: no previous prototype for 'malidp_duplicate_plane_state' [-Wmissing-prototypes]
> > drivers/gpu/drm/arm/malidp_planes.c:66:6: warning: no previous prototype for 'malidp_destroy_plane_state' [-Wmissing-prototypes]
> > 
> > In fact, both functions are only used in the file in which they are
> > declared and don't need a declaration, but can be made static.
> > So this patch marks these functions with 'static'.
> > 
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> > ---
> ...
> > @@ -63,7 +64,7 @@ struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane)
> >  	return &state->base;
> >  }
> >  
> > -void malidp_destroy_plane_state(struct drm_plane *plane,
> > +static void malidp_destroy_plane_state(struct drm_plane *plane,
> >  				struct drm_plane_state *state)
> >  {
> >  	struct malidp_plane_state *m_state = to_malidp_plane_state(state);
> > 
> 
> The change looks correct, but I notice that the two lines of the
> declaration are no longer aligned.
> 
> The file follows the normal style of aligning the argument list
> in the second line to line up with the opening '(', so please keep
> it that way.
> 
> 	Arnd
> 

Fixed it locally and pushed it into my public repo @ git://linux-arm.org/linux-ld.git for-upstream/mali-dp

I will send it to David Airlie as a pull request together with the other patches/cleanups.

Many thanks,
Liviu


-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/arm: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-10-22 11:20 +0200
  Re: [PATCH] drm/arm: mark symbols static where possible Arnd Bergmann <arnd@arndb.de> - 2016-10-24 12:20 +0200
    Re: [PATCH] drm/arm: mark symbols static where possible liviu.dudau@arm.com - 2016-10-24 20:00 +0200

csiph-web