Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1507472
| From | Dave Hansen <dave.hansen@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 2/8] mm: Add specialized fallback zonelist for coherent device memory nodes |
| Date | 2016-10-24 19:20 +0200 |
| Message-ID | <svR4J-2cv-5@gated-at.bofh.it> (permalink) |
| References | <svFdf-2Fn-3@gated-at.bofh.it> <svFdf-2Fn-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/23/2016 09:31 PM, Anshuman Khandual wrote: > +#ifdef CONFIG_COHERENT_DEVICE > + /* > + * Isolation requiring coherent device memory node's zones > + * should not be part of any other node's fallback zonelist > + * but it's own fallback list. > + */ > + if (isolated_cdm_node(node) && (pgdat->node_id != node)) > + continue; > +#endif Total nit: Why do you need an #ifdef here when you had +#ifdef CONFIG_COHERENT_DEVICE +#define node_cdm(nid) (NODE_DATA(nid)->coherent_device) +#define set_cdm_isolation(nid) (node_cdm(nid) = 1) +#define clr_cdm_isolation(nid) (node_cdm(nid) = 0) +#define isolated_cdm_node(nid) (node_cdm(nid) == 1) +#else +#define set_cdm_isolation(nid) () +#define clr_cdm_isolation(nid) () +#define isolated_cdm_node(nid) (0) +#endif in your last patch?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC 2/8] mm: Add specialized fallback zonelist for coherent device memory nodes Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2016-10-24 06:40 +0200
Re: [RFC 2/8] mm: Add specialized fallback zonelist for coherent device memory nodes Dave Hansen <dave.hansen@intel.com> - 2016-10-24 19:20 +0200
Re: [RFC 2/8] mm: Add specialized fallback zonelist for coherent device memory nodes Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2016-10-25 03:30 +0200
csiph-web