Re: [PATCH] net: skip genenerating uevents for network namespaces that are exiting

From	Cong Wang <xiyou.wangcong@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: skip genenerating uevents for network namespaces that are exiting
Date	2016-10-24 19:20 +0200
Message-ID	<svR4J-2cv-13@gated-at.bofh.it> (permalink)
References	<suy49-7Wf-31@gated-at.bofh.it> <suyxb-8lc-5@gated-at.bofh.it> <suAz0-1dh-9@gated-at.bofh.it> <suZ4m-oy-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Oct 22, 2016 at 12:37 AM, Andrey Vagin <avagin@openvz.org> wrote:
> Hi Cong,
>
> On Thu, Oct 20, 2016 at 10:25 PM, Andrey Vagin <avagin@openvz.org> wrote:
>> On Thu, Oct 20, 2016 at 8:10 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>> On Thu, Oct 20, 2016 at 7:46 PM, Andrei Vagin <avagin@openvz.org> wrote:
>>>> No one can see these events, because a network namespace can not be
>>>> destroyed, if it has sockets.
>>>>
>>>
>>> Are you sure? kobject_uevent_env() seems sending uevents to all
>>> network namespaces.
>>
>> kobj_bcast_filter() checks that a kobject namespace is equal to a
>> socket namespace.
>
> Today I've checked that it really works as I read from the source code.
> I use this tool to read events:
> https://gist.github.com/avagin/430ba431fc2972002df40ebe6a048b36
>
> And I see that events from non-network devices are delivered to all sockets,
> but events from network devices are delivered only to sockets from
> a network namespace where a device is operated.

I missed it, it makes sense now. Please consider adding a comment in
the code or expanding your changelog for reference.

Thanks!

Thread

[PATCH] net: skip genenerating uevents for network namespaces that are exiting Andrei Vagin <avagin@openvz.org> - 2016-10-21 04:50 +0200
  Re: [PATCH] net: skip genenerating uevents for network namespaces  that are exiting Cong Wang <xiyou.wangcong@gmail.com> - 2016-10-21 05:20 +0200
    Re: [PATCH] net: skip genenerating uevents for network namespaces  that are exiting Andrey Vagin <avagin@openvz.org> - 2016-10-21 07:30 +0200
      Re: [PATCH] net: skip genenerating uevents for network namespaces  that are exiting Andrey Vagin <avagin@openvz.org> - 2016-10-22 09:40 +0200
        Re: [PATCH] net: skip genenerating uevents for network namespaces  that are exiting Cong Wang <xiyou.wangcong@gmail.com> - 2016-10-24 19:20 +0200
  Re: [PATCH] net: skip genenerating uevents for network namespaces  that are exiting David Miller <davem@davemloft.net> - 2016-10-22 23:10 +0200

csiph-web