Re: [PATCH] ARC: return -EFAULT on failed access_ok for arc_usr_cmpxchg syscall

From	Vineet Gupta <Vineet.Gupta1@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARC: return -EFAULT on failed access_ok for arc_usr_cmpxchg syscall
Date	2016-10-24 18:00 +0200
Message-ID	<svPPj-1bs-7@gated-at.bofh.it> (permalink)
References	<svKZj-6tF-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/24/2016 03:47 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> arc_usr_cmpxchg currently returns an uninitialized value in ret
> on a failed access_ok call. Instead, return -EFAULT.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  arch/arc/kernel/process.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c
> index a746008..9ae3e1c 100644
> --- a/arch/arc/kernel/process.c
> +++ b/arch/arc/kernel/process.c
> @@ -47,7 +47,7 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, expected, int, new)
>  	int ret;
>  
>  	if (!access_ok(VERIFY_WRITE, uaddr, sizeof(int)))
> -		return ret;
> +		return -EFAULT;
>  
>  	preempt_disable();

Thx for spotting this. Since this is new code, not yet merged, do you mind if I
squash it with orig patch. I can add a Reviewed-by a SOB as you prefer.

Thx,
-Vineet

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARC: return -EFAULT on failed access_ok for arc_usr_cmpxchg syscall Colin King <colin.king@canonical.com> - 2016-10-24 12:50 +0200
  Re: [PATCH] ARC: return -EFAULT on failed access_ok for  arc_usr_cmpxchg syscall Colin Ian King <colin.king@canonical.com> - 2016-10-24 18:00 +0200
  Re: [PATCH] ARC: return -EFAULT on failed access_ok for  arc_usr_cmpxchg syscall Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-24 18:00 +0200

csiph-web