Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.
Date	2016-10-24 17:00 +0200
Message-ID	<svOTf-vq-1@gated-at.bofh.it> (permalink)
References	<spbUB-5Qv-5@gated-at.bofh.it> <serzI-4pL-7@gated-at.bofh.it> <seos9-2uF-13@gated-at.bofh.it> <set8u-5vV-9@gated-at.bofh.it> <spbUB-5Qv-5@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Artem Savkov <asavkov@redhat.com> wrote:

> > > IMO, the preferable fix depends on your future plan.
> > > If you plan to continue using both ANSI X9.31 DRNG and DRBG - I agree with the
> > > patch suggested by Artem Savkov.
> > > If you plan to reduce using ANSI X9.31 DRNG and use DRBG more widely - I
> > > suggest my patch.
> > 
> > No such plans, TBH.
> 
> I agre with Kirill here, so if we are not trying to reduce ANSI X9.31
> DRNG usage can we move on with the suggested patch, or are there any
> issues with it that need addressing?

Which suggested patch?  One of Kirill's (there are at least two) or yours?

Note that we *also* need the "KEYS: Sort out big_key initialisation" patch -
just changing the Kconfig is not sufficient a fix in and of itself.

David

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. David Howells <dhowells@redhat.com> - 2016-10-24 17:00 +0200
  Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. Artem Savkov <asavkov@redhat.com> - 2016-10-25 12:30 +0200
    Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. David Howells <dhowells@redhat.com> - 2016-10-25 13:40 +0200

csiph-web