Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1507164
| From | Yuriy Kolerov <yuriy.kolerov@synopsys.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 1/5] ARC: SMP: Use "unsigned virq" in smp_ipi_irq_setup instead of "signed irq" |
| Date | 2016-10-24 14:50 +0200 |
| Message-ID | <svMRr-7EB-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
This function takes a cpu number and a virq number and registers an
appropriate handler per cpu. However smp_ipi_irq_setup is incorrectly
used in several places of ARC platform code - hwirq is passed instead
of virq. This patch is intended to clarify declaration of virq argument
to prevent passing of hwirq instead of virq in future.
Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
---
arch/arc/include/asm/smp.h | 4 ++--
arch/arc/kernel/smp.c | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arc/include/asm/smp.h b/arch/arc/include/asm/smp.h
index 89fdd1b..3ebebbc 100644
--- a/arch/arc/include/asm/smp.h
+++ b/arch/arc/include/asm/smp.h
@@ -37,9 +37,9 @@ extern const char *arc_platform_smp_cpuinfo(void);
* API expected BY platform smp code (FROM arch smp code)
*
* smp_ipi_irq_setup:
- * Takes @cpu and @irq to which the arch-common ISR is hooked up
+ * Takes @cpu and @virq to which the arch-common ISR is hooked up
*/
-extern int smp_ipi_irq_setup(int cpu, int irq);
+extern int smp_ipi_irq_setup(int cpu, unsigned int virq);
/*
* struct plat_smp_ops - SMP callbacks provided by platform to ARC SMP
diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c
index f183cc6..ec4d956 100644
--- a/arch/arc/kernel/smp.c
+++ b/arch/arc/kernel/smp.c
@@ -351,7 +351,7 @@ irqreturn_t do_IPI(int irq, void *dev_id)
*/
static DEFINE_PER_CPU(int, ipi_dev);
-int smp_ipi_irq_setup(int cpu, int irq)
+int smp_ipi_irq_setup(int cpu, unsigned int virq)
{
int *dev = per_cpu_ptr(&ipi_dev, cpu);
@@ -359,12 +359,12 @@ int smp_ipi_irq_setup(int cpu, int irq)
if (!cpu) {
int rc;
- rc = request_percpu_irq(irq, do_IPI, "IPI Interrupt", dev);
+ rc = request_percpu_irq(virq, do_IPI, "IPI Interrupt", dev);
if (rc)
- panic("Percpu IRQ request failed for %d\n", irq);
+ panic("Percpu IRQ request failed for %d\n", virq);
}
- enable_percpu_irq(irq, 0);
+ enable_percpu_irq(virq, 0);
return 0;
}
--
2.7.4
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH v2 1/5] ARC: SMP: Use "unsigned virq" in smp_ipi_irq_setup instead of "signed irq" Yuriy Kolerov <yuriy.kolerov@synopsys.com> - 2016-10-24 14:50 +0200
[PATCH v2 2/5] ARC: SMP: Pass virq to smp_ipi_irq_setup instead of hwirq Yuriy Kolerov <yuriy.kolerov@synopsys.com> - 2016-10-24 14:50 +0200
Re: [PATCH v2 2/5] ARC: SMP: Pass virq to smp_ipi_irq_setup instead of hwirq Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-25 04:30 +0200
[PATCH v2 3/5] ARC: MCIP: Use hwirq instead of virq for resolution of IDU IRQ handlers Yuriy Kolerov <yuriy.kolerov@synopsys.com> - 2016-10-24 14:50 +0200
[PATCH v2 4/5] ARC: MCIP: Set an initial affinity value in idu_irq_map Yuriy Kolerov <yuriy.kolerov@synopsys.com> - 2016-10-24 14:50 +0200
Re: [PATCH v2 4/5] ARC: MCIP: Set an initial affinity value in idu_irq_map Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-25 20:30 +0200
Re: [PATCH v2 4/5] ARC: MCIP: Set an initial affinity value in idu_irq_map Marc Zyngier <marc.zyngier@arm.com> - 2016-10-26 16:10 +0200
Re: [PATCH v2 4/5] ARC: MCIP: Set an initial affinity value in idu_irq_map Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-26 18:20 +0200
Re: [PATCH v2 4/5] ARC: MCIP: Set an initial affinity value in idu_irq_map Marc Zyngier <marc.zyngier@arm.com> - 2016-10-26 18:40 +0200
Re: [PATCH v2 4/5] ARC: MCIP: Set an initial affinity value in idu_irq_map Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-26 19:30 +0200
Re: [PATCH v2 1/5] ARC: SMP: Use "unsigned virq" in smp_ipi_irq_setup instead of "signed irq" Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-24 22:10 +0200
Re: [PATCH v2 1/5] ARC: SMP: Use "unsigned virq" in smp_ipi_irq_setup instead of "signed irq" Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-25 04:30 +0200
RE: [PATCH v2 1/5] ARC: SMP: Use "unsigned virq" in smp_ipi_irq_setup instead of "signed irq" Yuriy Kolerov <Yuriy.Kolerov@synopsys.com> - 2016-10-25 19:30 +0200
csiph-web