Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1507117

Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user
Date 2016-10-24 13:40 +0200
Message-ID <svLLI-6ZR-27@gated-at.bofh.it> (permalink)
References <svHoK-40i-3@gated-at.bofh.it> <svL90-6xn-3@gated-at.bofh.it> <svLiF-6PQ-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> I didn't think it looked totally correct, but I'm not sure it's any
> more broken then what is already in the tree.

It's not more broken.  But better to leave the compile warning there to
mark that it is an obvious security problem.

> 
> If you can kindly point me to some other source code or documentation
> to look at that is correct, I'm more then willing to fix the patch.
> 

I was hoping the maintainers could chip in, because I didn't want to
look at the code.  We really need to track which are use pointers and
which are kernel pointers.  We can't mix them like this.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user mzoran@crowfest.net - 2016-10-24 09:00 +0200
  Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-24 13:00 +0200
    Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Michael Zoran <mzoran@crowfest.net> - 2016-10-24 13:10 +0200
      Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-24 13:40 +0200
        Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Michael Zoran <mzoran@crowfest.net> - 2016-10-24 13:50 +0200
          Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-24 14:00 +0200
            Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Michael Zoran <mzoran@crowfest.net> - 2016-10-24 14:20 +0200
              Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-24 14:40 +0200
  Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Greg KH <gregkh@linuxfoundation.org> - 2016-10-24 15:30 +0200
    Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Michael Zoran <mzoran@crowfest.net> - 2016-10-24 16:30 +0200
      Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-24 16:50 +0200
        Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in  vchiq_copy_from_user Michael Zoran <mzoran@crowfest.net> - 2016-10-24 17:50 +0200

csiph-web