Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

From	Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver
Date	2016-10-24 11:10 +0200
Message-ID	<svJqy-5wS-23@gated-at.bofh.it> (permalink)
References	(1 earlier) <scVLz-7Si-5@gated-at.bofh.it> <scVLz-7Si-7@gated-at.bofh.it> <scVLz-7Si-9@gated-at.bofh.it> <suHKa-5WG-19@gated-at.bofh.it> <svE7w-1Xn-3@gated-at.bofh.it>
Organization	Samsung

Show all headers | View raw

Em Mon, 24 Oct 2016 11:22:08 +0800
Tiffany Lin <tiffany.lin@mediatek.com> escreveu:

> Hi Mauro,
> 
> On Fri, 2016-10-21 at 11:01 -0200, Mauro Carvalho Chehab wrote:
> > Em Fri, 2 Sep 2016 20:19:54 +0800
> > Tiffany Lin <tiffany.lin@mediatek.com> escreveu:
> >   
> > > Add v4l2 layer decoder driver for MT8173
> > > 
> > > Signed-off-by: Tiffany Lin <tiffany.lin@mediatek.com>  
> >   
> > > +int vdec_if_init(struct mtk_vcodec_ctx *ctx, unsigned int fourcc)
> > > +{
> > > +	int ret = 0;
> > > +
> > > +	switch (fourcc) {
> > > +	case V4L2_PIX_FMT_H264:
> > > +	case V4L2_PIX_FMT_VP8:
> > > +	default:
> > > +		return -EINVAL;
> > > +	}  
> > 
> > Did you ever test this driver? The above code will *always* return
> > -EINVAL, with will cause vidioc_vdec_s_fmt() to always fail!
> > 
> > I suspect that what you wanted to do, instead, is:
> > 
> > 	switch (fourcc) {
> > 	case V4L2_PIX_FMT_H264:
> > 	case V4L2_PIX_FMT_VP8:
> > 		break;
> > 	default:
> > 		return -EINVAL;
> >   
> 
> The original idea here is that vp8 and h264 are added in later patches.
> If get this patch without later patches, it should return -EINVAL.

I noticed your idea, but next time, don't add dead code like that.
Reviewers check patch by patch at the order they're present at the
patch series.

So, don't add something broken by purpose, assuming that it would
be fixed later.

> 
> 
> > Btw, this patch series has also several issues that were pointed by
> > checkpatch. Please *always* run checkpatch when submitting your work.
> > 
> > You should take a look at the Kernel documentation about how to
> > submit patches, at:
> > 	https://mchehab.fedorapeople.org/kernel_docs/process/index.html
> > 
> > PS.: this time, I fixed the checkpatch issues for you. So, let me know
> > if the patch below is OK, and I'll merge it at media upstream,
> > assuming that the other patches in this series are ok.
> >   
> 
> I did run checkpatch, but I don't know why these issues missed.
> probably I run checkpatch for all files not for patches.
> I will take a look at the documentation and keep this in mind for future
> upstream.
> Appreciated for your help.

Checkpatch should be run patch by patch, as we expect that all patches
will follow the coding style and will compile fine, without introducing
warnings.

I do compile the Kernel for every single patch I merge.

Regards,
Mauro

Thread

Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video  Decoder Driver Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-10-21 15:10 +0200
  Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video  Decoder Driver Tiffany Lin <tiffany.lin@mediatek.com> - 2016-10-24 05:30 +0200
    Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video  Decoder Driver Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-10-24 11:10 +0200
      Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video  Decoder Driver Tiffany Lin <tiffany.lin@mediatek.com> - 2016-10-24 12:50 +0200

csiph-web