Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1506896

Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

From khalasa@piap.pl (Krzysztof Hałasa)
Newsgroups linux.kernel
Subject Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write
Date 2016-10-24 07:00 +0200
Message-ID <svFwB-2Mn-9@gated-at.bofh.it> (permalink)
References <sv5CO-4Fd-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Andrey Utkin <andrey.utkin@corp.bluecherry.net> writes:

> --- a/drivers/media/pci/solo6x10/solo6x10.h
> +++ b/drivers/media/pci/solo6x10/solo6x10.h
> @@ -284,7 +284,10 @@ static inline u32 solo_reg_read(struct solo_dev *solo_dev, int reg)
>  static inline void solo_reg_write(struct solo_dev *solo_dev, int reg,
>  				  u32 data)
>  {
> +	u16 val;
> +
>  	writel(data, solo_dev->reg_base + reg);
> +	pci_read_config_word(solo_dev->pdev, PCI_STATUS, &val);
>  }
>  
>  static inline void solo_irq_on(struct solo_dev *dev, u32 mask)

This is ok for now. I hope I will find some to refine this, so not all
register writes are done with the penalty - eventually.
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write Andrey Utkin <andrey.utkin@corp.bluecherry.net> - 2016-10-22 16:40 +0200
  Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write khalasa@piap.pl (Krzysztof Hałasa) - 2016-10-24 07:00 +0200
    Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed  register write Andrey Utkin <andrey_utkin@fastmail.com> - 2016-10-24 09:20 +0200

csiph-web