Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506812

Re: [PATCH] gpio: mcp23s08: Add option to configure pullups.

Show all headers | View raw

On Fri, Oct 21, 2016 at 5:00 PM, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:

> Default is without pullups, but if property is specified in DT and the bit
> is set, set a pullup on GPIO-n.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

I don't generally like this.

In device tree it is the consumer that specifies how the line is used,
not the producer (gpiochip).

We currently only specify polarity, open drain and open source
for consumers though.

And the entire pin control system came into being *exactly* because
Grant didn't like me adding these things to the GPIO drivers.

So how many other things does the MCP support? Drive strength?
Schmitt trigger? Is there a datasheet?

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: mcp23s08: Add option to configure pullups. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2016-10-21 17:10 +0200
  Re: [PATCH] gpio: mcp23s08: Add option to configure pullups. Linus Walleij <linus.walleij@linaro.org> - 2016-10-24 03:00 +0200
    Re: [PATCH] gpio: mcp23s08: Add option to configure pullups. Alexander Stein <alexander.stein@systec-electronic.com> - 2016-10-24 08:20 +0200
      Re: [PATCH] gpio: mcp23s08: Add option to configure pullups. Enric Balletbo Serra <eballetbo@gmail.com> - 2016-10-26 12:00 +0200

csiph-web