Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506794

Re: [PATCH] pinctrl: st: don't specify default interrupt trigger

Show all headers | View raw

On Tue, Oct 18, 2016 at 9:16 AM,  <patrice.chotard@st.com> wrote:

> From: Patrice Chotard <patrice.chotard@st.com>
>
> Thanks to 332e99d5ae4 which now alerts of default
> trigger usage when configuring interrupts.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>

Patch applied with Peter's ACK.

Pls also look into the following: __gpio_irq_handler seems to be
doing some stuff per-IRQ that only pertains to edge-triggered IRQs.
Normally that should be handled by:

- Setting default handler to handle_bad_irq()
- Setting handler to handle_edge_irq() or handle_level_irq() in .set_type()
- Implement .irq_ack() on the irqchip and handle the edge-specific ACKing
  there.

See for example drivers/gpio/gpio-pl061.c.

I am not *sure* this applies to pinctrl-st.c but please check if it provides
more elegant code. Notmally the .irq_ack() is for edge detection hardware
that allows ACKing the ege IRQ in a separate register and after that we
can raise another edge IRQ while the current IRQ is being handled.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: st: don't specify default interrupt trigger <patrice.chotard@st.com> - 2016-10-18 09:20 +0200
  Re: [PATCH] pinctrl: st: don't specify default interrupt trigger Patrice Chotard <patrice.chotard@st.com> - 2016-10-20 13:40 +0200
    Re: [PATCH] pinctrl: st: don't specify default interrupt trigger Peter Griffin <peter.griffin@linaro.org> - 2016-10-20 14:00 +0200
  Re: [PATCH] pinctrl: st: don't specify default interrupt trigger Linus Walleij <linus.walleij@linaro.org> - 2016-10-24 01:40 +0200

csiph-web