Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506788

Re: [PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of GPIO controller

Show all headers | View raw

On Thu, Oct 20, 2016 at 1:45 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> [Ville]
>>  The gpio_chip->label which is
>> used for the lookup is based on KBUILD_MODNAME and the moduled is
>> called gpio-crystalcove.
>
> ...which I think is wrong. Only few drivers are binding to file / module
> name.
>
> Perhaps it should be fixed all together.
>
> Naming a bit chaotic in drivers/gpio/*::chip.label, though majority of
> them are using dev_name() of actual device.
>
> Linus, what is your opinion?

The docs says:

/**
 * struct gpio_chip - abstract a GPIO controller
 * @label: a functional name for the GPIO device, such as a part
 *      number or the name of the SoC IP-block implementing it.

Apart from that it is just a name. It does not need to be unique per
instance since the gpiocip0 ... gpiochipN plus sysfs topology
takes care of identifying the chip. I have no strong opinion on it.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of GPIO controller Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-20 11:40 +0200
  Re: [PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of  GPIO controller Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-10-20 13:20 +0200
    Re: [PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of  GPIO controller Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-20 13:50 +0200
      Re: [PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of  GPIO controller Linus Walleij <linus.walleij@linaro.org> - 2016-10-24 01:30 +0200

csiph-web