Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1505347

Re: [PATCH] remoteproc: Add support for xo clock

From Stephen Boyd <sboyd@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH] remoteproc: Add support for xo clock
Date 2016-10-21 02:00 +0200
Message-ID <suvpE-5VC-3@gated-at.bofh.it> (permalink)
References <suqJj-2WR-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 10/20, Sarangdhar Joshi wrote:
> Add xo clock support required for Qualcomm ADSP
> Peripheral Image Loader.

Yes but why is xo needed?

> @@ -223,6 +232,17 @@ static irqreturn_t adsp_stop_ack_interrupt(int irq, void *dev)
>  	return IRQ_HANDLED;
>  }
>  
> +static int adsp_init_clock(struct qcom_adsp *adsp)
> +{
> +	adsp->xo = devm_clk_get(adsp->dev, "xo");
> +	if (IS_ERR(adsp->xo)) {
> +		dev_err(adsp->dev, "failed to get xo clock");

What if it's a probe defer error? Probably best to just be
silent/debug level, or we need a specific test for EPROBE_DEFER
and then silence in that case.

> +		return PTR_ERR(adsp->xo);
> +	}

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] remoteproc: Add support for xo clock Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-20 21:00 +0200
  Re: [PATCH] remoteproc: Add support for xo clock Stephen Boyd <sboyd@codeaurora.org> - 2016-10-21 02:00 +0200
    Re: [PATCH] remoteproc: Add support for xo clock Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-22 01:20 +0200

csiph-web