Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1505295

Re: [PATCH v2] pinctrl: Add SX150X GPIO Extender Pinctrl Driver

Show all headers | View raw

On Tue, Sep 27, 2016 at 5:48 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:

> Since the I2C sx150x GPIO expander driver uses platform_data to manage
> the pins configurations, rewrite the driver as a pinctrl driver using
> pinconf to get/set pin configurations from DT or debugfs.
>
> The pinctrl driver is functionnally equivalent as the gpio-only driver
> and can use DT for pinconf. The platform_data confirmation is dropped.
>
> This patchset removed the gpio-only driver and selects the Pinctrl driver
> config instead. This patchset also migrates the gpio dt-bindings to pinctrl
> and add the pinctrl optional properties.
>
> The driver was tested with a SX1509 device on a BeagleBone black with
> interrupt support and on an X86_64 machine over an I2C to USB converter.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

I think we're ready to apply this to the GPIO and pinctrl trees.
Could you:

- Rebase on top of v4.9-rc1 (fails to apply for me)
- Add the collected ACKs
- See if Andrey can provide an additional Test tag
- Resend

Also please look at Andreys patches to see if there is some good
inspiration for further cleanups.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] pinctrl: Add SX150X GPIO Extender Pinctrl Driver Linus Walleij <linus.walleij@linaro.org> - 2016-10-21 00:10 +0200

csiph-web