Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1505297
| From | Sarangdhar Joshi <spjoshi@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes |
| Date | 2016-10-21 00:10 +0200 |
| Message-ID | <sutHc-52m-27@gated-at.bofh.it> (permalink) |
| References | <suqJj-2WR-7@gated-at.bofh.it> <suqJk-2WR-19@gated-at.bofh.it> <surFo-3wn-11@gated-at.bofh.it> <sut4u-4yl-19@gated-at.bofh.it> <sutxw-4IC-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/20/2016 02:51 PM, Andy Gross wrote:
> On Thu, Oct 20, 2016 at 02:18:33PM -0700, Sarangdhar Joshi wrote:
>> On 10/20/2016 12:56 PM, Bjorn Andersson wrote:
>>> On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
>>>
>>>> From: Bjorn Andersson <bjorn.andersson@linaro.org>
>>>>
>>>> Add SMEM and TCSR DT nodes on MSM8996.
>>>>
>>>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>>>> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
>>>> 1 file changed, 19 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> index 949b096..0a810f5 100644
>>>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> @@ -169,12 +169,31 @@
>>>> method = "smc";
>>>> };
>>>>
>>>> + smem {
>>>> + compatible = "qcom,smem";
>>>> +
>>>> + memory-region = <&smem_mem>;
>>>> +
>>>> + hwlocks = <&tcsr_mutex 3>;
>>>> + };
>>>> +
>>>> soc: soc {
>>>> #address-cells = <1>;
>>>> #size-cells = <1>;
>>>> ranges = <0 0 0 0xffffffff>;
>>>> compatible = "simple-bus";
>>>>
>>>> + tcsr_mutex_regs: syscon@740000 {
>>>> + compatible = "syscon";
>>>> + reg = <0x740000 0x20000>;
>>>> + };
>>>> +
>>>> + tcsr_mutex: hwlock {
>>>> + compatible = "qcom,tcsr-mutex";
>>>> + syscon = <&tcsr_mutex_regs 0 0x1000>;
>>>> + #hwlock-cells = <1>;
>>>> + };
>>>
>>> Sorry, I got this in the wrong place, the hwlock node should sit outside
>>> of soc {} - looks like we got this wrong in msm8916 as well.
>>
>> Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e.
>> root)?
>
> Yes. Any node that doesn't have reg properties should go under the root.
>
Got it. Will update the patch(es) and add cover letter. Thanks.
>
> Andy
>
Regards,
Sarang
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/4] arm64: dts: msm8996: Add SMEM reserve-memory node Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-20 21:00 +0200
[PATCH 4/4] arm64: dts: msm8996: Add SMP2P and APCS nodes Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-20 21:00 +0200
Re: [PATCH 4/4] arm64: dts: msm8996: Add SMP2P and APCS nodes Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-10-20 22:10 +0200
Re: [PATCH 4/4] arm64: dts: msm8996: Add SMP2P and APCS nodes Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-20 23:30 +0200
[PATCH 2/4] arm64: dts: msm8996: Add reserve-memory nodes Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-20 21:00 +0200
Re: [PATCH 2/4] arm64: dts: msm8996: Add reserve-memory nodes Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-10-20 22:00 +0200
Re: [PATCH 2/4] arm64: dts: msm8996: Add reserve-memory nodes Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-20 23:20 +0200
[PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-20 21:00 +0200
Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-10-20 22:00 +0200
Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-20 23:30 +0200
Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes Andy Gross <andy.gross@linaro.org> - 2016-10-21 00:00 +0200
Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-21 00:10 +0200
Re: [PATCH 1/4] arm64: dts: msm8996: Add SMEM reserve-memory node Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-10-20 22:00 +0200
Re: [PATCH 1/4] arm64: dts: msm8996: Add SMEM reserve-memory node Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-10-20 23:20 +0200
Re: [PATCH 1/4] arm64: dts: msm8996: Add SMEM reserve-memory node Andy Gross <andy.gross@linaro.org> - 2016-10-21 00:00 +0200
csiph-web