Re: [PATCH] net: smc91x: fix neponset breakage by pxa u16 writes

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: smc91x: fix neponset breakage by pxa u16 writes
Date	2016-10-20 17:30 +0200
Message-ID	<suns6-Ws-21@gated-at.bofh.it> (permalink)
References	<su6AW-6Om-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: Wed, 19 Oct 2016 23:23:50 +0200

> The patch isolating the u16 writes for pxa assumed all machine_is_*()
> calls were removed, and therefore removed the mach-types.h include which
> provided them.
> 
> Unfortunately 2 machine_is_*() remained in smc91x.c file including
> smc91x.h from which the include was removed, triggering the error:
>  drivers/net/ethernet/smsc/smc91x.c: In function ‘smc_drv_probe’:
>  drivers/net/ethernet/smsc/smc91x.c:2380:2: error: implicit declaration
>  of function ‘machine_is_assabet’
>  [-Werror=implicit-function-declaration]
> 	if (machine_is_assabet() && machine_has_neponset())
> 
> This adds back the wrongly removed include.
> 
> Fixes: d09d747ae4c2 ("net: smc91x: isolate u16 writes alignment workaround")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: smc91x: fix neponset breakage by pxa u16 writes Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-19 23:30 +0200
  Re: [PATCH] net: smc91x: fix neponset breakage by pxa u16 writes David Miller <davem@davemloft.net> - 2016-10-20 17:30 +0200

csiph-web