RE: [PATCH] qedr: return -EINVAL if pd is null and avoid null ptr dereference

From	"Amrani, Ram" <Ram.Amrani@cavium.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] qedr: return -EINVAL if pd is null and avoid null ptr dereference
Date	2016-10-20 11:50 +0200
Message-ID	<sui93-5JM-5@gated-at.bofh.it> (permalink)
References	<stHCy-5H5-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>  drivers/infiniband/hw/qedr/verbs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/qedr/verbs.c
> b/drivers/infiniband/hw/qedr/verbs.c
> index a615142..b2a0eb8 100644
> --- a/drivers/infiniband/hw/qedr/verbs.c
> +++ b/drivers/infiniband/hw/qedr/verbs.c
> @@ -511,8 +511,10 @@ int qedr_dealloc_pd(struct ib_pd *ibpd)
>  	struct qedr_dev *dev = get_qedr_dev(ibpd->device);
>  	struct qedr_pd *pd = get_qedr_pd(ibpd);
> 
> -	if (!pd)
> +	if (!pd) {
>  		pr_err("Invalid PD received in dealloc_pd\n");
> +		return -EINVAL;
> +	}
> 
>  	DP_DEBUG(dev, QEDR_MSG_INIT, "Deallocating PD %d\n", pd->pd_id);
>  	dev->ops->rdma_dealloc_pd(dev->rdma_ctx, pd->pd_id);
> --
> 2.9.3

Thanks Colin.

Acked-by: Ram Amrani <ram.amrani@cavium.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] qedr: return -EINVAL if pd is null and avoid null ptr dereference Colin King <colin.king@canonical.com> - 2016-10-18 20:50 +0200
  RE: [PATCH] qedr: return -EINVAL if pd is null and avoid null ptr  dereference "Amrani, Ram" <Ram.Amrani@cavium.com> - 2016-10-20 11:50 +0200

csiph-web