Re: [PATCH] checkpatch: don't match against empty $const_structs

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] checkpatch: don't match against empty $const_structs
Date	2016-10-20 10:20 +0200
Message-ID	<sugJX-50e-17@gated-at.bofh.it> (permalink)
References	<sugJX-50e-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-10-20 at 10:12 +0200, Jerome Forissier wrote:
> When $conststructsfile does not exist or is empty, we may get false
> warnings such as:
> WARNING: struct  should normally be const
> 
> Fix that by not running the string match if $const_structs is empty.

Why should $const_structs ever be empty?

> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1..722a319 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -6010,7 +6010,8 @@ sub process {
>  		}
>  
>  # check for various structs that are normally const (ops, kgdb, device_tree)
> -		if ($line !~ /\bconst\b/ &&
> +		if ($const_structs ne "" &&
> +		    $line !~ /\bconst\b/ &&
>  		    $line =~ /\bstruct\s+($const_structs)\b/) {
>  			WARN("CONST_STRUCT",
>  			     "struct $1 should normally be const\n" .
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] checkpatch: don't match against empty $const_structs Joe Perches <joe@perches.com> - 2016-10-20 10:20 +0200
  Re: [PATCH] checkpatch: don't match against empty $const_structs Jerome Forissier <jerome.forissier@linaro.org> - 2016-10-20 10:20 +0200
    Re: [PATCH] checkpatch: don't match against empty $const_structs Joe Perches <joe@perches.com> - 2016-10-20 10:30 +0200

csiph-web