Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1504464

RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

From "Kershner, David A" <David.Kershner@unisys.com>
Newsgroups linux.kernel
Subject RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.
Date 2016-10-20 04:40 +0200
Message-ID <subqW-1tl-9@gated-at.bofh.it> (permalink)
References <su1hU-3b7-31@gated-at.bofh.it> <su6Uh-6V4-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Cathal Mullaney [mailto:chuckleberryfinn@gmail.com]
> Subject: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking
> code to be statically deterministic.
> 
> This patch makes locking in visorchannel_signalempty statically
> deterministic.
> As a result this patch fixes the sparse warning:
> Context imbalance in 'visorchannel_signalempty' - different lock
> contexts for basic block.
> 
> The logic of the locking code doesn't change but the layout of the
> original code is "frowned upon"
> according to mails on sparse context checking.
> Refactoring removes the warning and makes the code more readable.
> 
> Signed-off-by: Cathal Mullaney <chuckleberryfinn@gmail.com>

Tested-by: David Kershner <david.kershner@unisys.com>

> ---
> V2: Removed unnecessary variable initialization, as suggested by Tim Sell
> <Timothy.Sell@unisys.com>.
> 
>  drivers/staging/unisys/visorbus/visorchannel.c | 30 ++++++++++++++++----
> ------

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic. Cathal Mullaney <chuckleberryfinn@gmail.com> - 2016-10-19 17:50 +0200
  RE: [PATCH] staging: unisys: visorbus: visorchannel: Refactor locking  code to be statically deterministic. "Sell, Timothy C" <Timothy.Sell@unisys.com> - 2016-10-19 22:40 +0200
    Re: [PATCH] staging: unisys: visorbus: visorchannel: Refactor  locking code to be statically deterministic. Chuckleberryfinn <chuckleberryfinn@gmail.com> - 2016-10-20 00:00 +0200
  [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic. Cathal Mullaney <chuckleberryfinn@gmail.com> - 2016-10-19 23:50 +0200
    RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor  locking code to be statically deterministic. "Kershner, David A" <David.Kershner@unisys.com> - 2016-10-20 04:40 +0200
      RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor  locking code to be statically deterministic. "Sell, Timothy C" <Timothy.Sell@unisys.com> - 2016-10-20 05:20 +0200

csiph-web