Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506299

Re: [PATCH 1/2] perf_event_open.2: Document PERF_EVENT_IOC_PAUSE_OUTPUT

From Vince Weaver <vincent.weaver@maine.edu>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] perf_event_open.2: Document PERF_EVENT_IOC_PAUSE_OUTPUT
Date 2016-10-21 23:20 +0200
Message-ID <suPom-2G3-9@gated-at.bofh.it> (permalink)
References <suGl5-4T9-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, 21 Oct 2016, Wang Nan wrote:


> -.SS Using prctl(2)
> +.SS Using prctl

why this change?

> +.BR PERF_EVENT_IOC_PAUSE_OUTPUT " (since Linux 4.7)"
> +.\" commit 86e7972f690c1017fd086cdfe53d8524e68c661c
> +This allows pausing and resuming the event's ring-buffer. A
> +paused ring-buffer does not prevent samples generation, but simply
> +discards them. The discarded samples are considered lost, causes
> +.BR PERF_RECORD_LOST
> +to be generated when possible.

I don't know if it's worth mentioning that the reason to add this is to 
allow reading the ring-buffer without having to worry about data being
overwritten.

There are a few odd wording choices (mostly plural nouns) but otherwise 
looks fine to me.

Reviewed-by: Vince Weaver <vincent.weaver@maine.edu>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] perf_event_open.2: Document PERF_EVENT_IOC_PAUSE_OUTPUT Wang Nan <wangnan0@huawei.com> - 2016-10-21 13:40 +0200
  [PATCH 2/2] perf_event_open.2: Document write_backward Wang Nan <wangnan0@huawei.com> - 2016-10-21 13:50 +0200
    Re: [PATCH 2/2] perf_event_open.2: Document write_backward Vince Weaver <vincent.weaver@maine.edu> - 2016-10-21 23:30 +0200
      Re: [PATCH 2/2] perf_event_open.2: Document write_backward "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-10-22 12:10 +0200
        Re: [PATCH 2/2] perf_event_open.2: Document write_backward "Wangnan (F)" <wangnan0@huawei.com> - 2016-10-24 08:50 +0200
  Re: [PATCH 1/2] perf_event_open.2: Document  PERF_EVENT_IOC_PAUSE_OUTPUT Vince Weaver <vincent.weaver@maine.edu> - 2016-10-21 23:20 +0200
    Re: [PATCH 1/2] perf_event_open.2: Document  PERF_EVENT_IOC_PAUSE_OUTPUT "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-10-22 12:10 +0200
  Re: [PATCH 1/2] perf_event_open.2: Document  PERF_EVENT_IOC_PAUSE_OUTPUT "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-10-22 12:10 +0200

csiph-web