[PATCH] checkpatch: Fix warnings when --no-tree is used

From	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH] checkpatch: Fix warnings when --no-tree is used
Date	2016-10-21 22:30 +0200
Message-ID	<suOBY-2ad-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

When users run checkpatch.pl with --no-tree option, $root is not
defined, which causes an ugly warning that it is not initialized at
line 764.  The test for whether or not a file is maintained should
only be run when a kernel tree is defined (i.e. not when --no-tree
option is being used)

Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a8368d1..7a54978 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2352,7 +2352,7 @@ sub process {
 			}
 		}
 
-		if ($found_file) {
+		if ($found_file && $tree) {
 			if (is_maintained_obsolete($realfile)) {
 				WARN("OBSOLETE",
 				     "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy.  No unnecessary modifications please.\n");
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] checkpatch: Fix warnings when --no-tree is used Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2016-10-21 22:30 +0200

csiph-web