Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1506232
| From | Marek Vasut <marek.vasut@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/3] mtd: s3c2410: make ecc mode configurable via platform data |
| Date | 2016-10-21 21:00 +0200 |
| Message-ID | <suNcR-16b-1@gated-at.bofh.it> (permalink) |
| References | <sutnP-4EY-9@gated-at.bofh.it> <sutnP-4EY-11@gated-at.bofh.it> <suMJP-VN-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/21/2016 08:27 PM, Krzysztof Kozlowski wrote: > On Thu, Oct 20, 2016 at 07:42:44PM -0200, Sergio Prado wrote: >> Removing CONFIG_MTD_NAND_S3C2410_HWECC option and adding a ecc_mode >> field in the drivers's platform data structure so it can be selectable >> via platform data. >> >> Also setting this field to NAND_ECC_SOFT in all boards using this >> driver since none of them had CONFIG_MTD_NAND_S3C2410_HWECC enabled. >> >> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com> >> --- >> arch/arm/mach-s3c24xx/common-smdk.c | 1 + >> arch/arm/mach-s3c24xx/mach-anubis.c | 1 + >> arch/arm/mach-s3c24xx/mach-at2440evb.c | 1 + >> arch/arm/mach-s3c24xx/mach-bast.c | 1 + >> arch/arm/mach-s3c24xx/mach-gta02.c | 1 + >> arch/arm/mach-s3c24xx/mach-jive.c | 1 + >> arch/arm/mach-s3c24xx/mach-mini2440.c | 1 + >> arch/arm/mach-s3c24xx/mach-osiris.c | 1 + >> arch/arm/mach-s3c24xx/mach-qt2410.c | 1 + >> arch/arm/mach-s3c24xx/mach-rx1950.c | 1 + >> arch/arm/mach-s3c24xx/mach-rx3715.c | 1 + >> arch/arm/mach-s3c24xx/mach-vstms.c | 1 + >> arch/arm/mach-s3c64xx/mach-hmt.c | 1 + >> arch/arm/mach-s3c64xx/mach-mini6410.c | 1 + >> arch/arm/mach-s3c64xx/mach-real6410.c | 1 + >> drivers/mtd/nand/Kconfig | 9 -- >> drivers/mtd/nand/s3c2410.c | 119 +++++++++++++------------ >> include/linux/platform_data/mtd-nand-s3c2410.h | 6 +- >> 18 files changed, 79 insertions(+), 70 deletions(-) >> > > I acked this twice (v1 and v2)... and still you are ignoring them. I am > sorry, I am not gonna to ack this third time! Hi, um, I am kinda new to this mess, what's going on ? You ACKed previous patches, next revision was submitted, so you need to ACK the next revision too (due to the changes). > For v2 I acked also other patches but it it is not there as well... > > BR, > Krzysztof -- Best regards, Marek Vasut
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/3] mtd: s3c2410: add device tree support Sergio Prado <sergio.prado@e-labworks.com> - 2016-10-20 23:50 +0200
[PATCH v3 3/3] mtd: s3c2410: parse the device configuration from OF node Sergio Prado <sergio.prado@e-labworks.com> - 2016-10-20 23:50 +0200
Re: [PATCH v3 3/3] mtd: s3c2410: parse the device configuration from OF node Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-24 15:10 +0200
Re: [PATCH v3 3/3] mtd: s3c2410: parse the device configuration from OF node Sergio Prado <sergio.prado@e-labworks.com> - 2016-10-24 20:50 +0200
Re: [PATCH v3 3/3] mtd: s3c2410: parse the device configuration from OF node Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-24 21:00 +0200
[PATCH v3 2/3] dt-bindings: mtd: add DT binding for s3c2410 flash controller Sergio Prado <sergio.prado@e-labworks.com> - 2016-10-20 23:50 +0200
Re: [PATCH v3 2/3] dt-bindings: mtd: add DT binding for s3c2410 flash controller Rob Herring <robh@kernel.org> - 2016-10-27 01:20 +0200
[PATCH v3 1/3] mtd: s3c2410: make ecc mode configurable via platform data Sergio Prado <sergio.prado@e-labworks.com> - 2016-10-20 23:50 +0200
Re: [PATCH v3 1/3] mtd: s3c2410: make ecc mode configurable via platform data Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-21 20:30 +0200
Re: [PATCH v3 1/3] mtd: s3c2410: make ecc mode configurable via platform data Marek Vasut <marek.vasut@gmail.com> - 2016-10-21 21:00 +0200
Re: [PATCH v3 1/3] mtd: s3c2410: make ecc mode configurable via platform data Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-21 22:10 +0200
Re: [PATCH v3 1/3] mtd: s3c2410: make ecc mode configurable via platform data Sergio Prado <sergio.prado@e-labworks.com> - 2016-10-21 21:10 +0200
Re: [PATCH v3 1/3] mtd: s3c2410: make ecc mode configurable via platform data Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-22 14:30 +0200
Re: [PATCH v3 1/3] mtd: s3c2410: make ecc mode configurable via platform data Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-22 17:40 +0200
csiph-web