Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506045

Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump

Show all headers | View raw

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 21 Oct 2016 06:14:23 -0700

> On Fri, 2016-10-21 at 14:56 +0200, Jiri Kosina wrote:
>> On Fri, 21 Oct 2016, Eric Dumazet wrote:
>> 
>> > Some of us are dealing with huge HTB hierarchies, so adding default fifo
>> > in the dump will add more data pumped from the kernel.
>> > 
>> > BwE [1] for instance dumps qdisc/classes every 5 seconds.
>> > 
>> > I guess we'll need to not pull this patch in our kernels.
>> 
>> Okay, so I probably misunderstood you here:
>> 
>> 	https://marc.info/?l=linux-kernel&m=146073234818214&w=2
>> 
>> as I thought that as long as we move towards the hashtable, you wouldn't 
>> have any issues with this.
>> 
>> I'd really like to unhide the default qdiscs, it makes little sense to be 
>> inconsistent in this way.
>> 
>> Random shot into darkness -- how about making this a 
>> CONFIG/sysctl-selectable?
> 
> Oh sorry for the confusion, I believe your patch is fine.
> 
> We could add an netlink attribute later for the users that really do not
> want default fifo being dumped, but there is no hurry.

If this is changing default behavior we should approach this the other
way around.

Keep behaving the way we do, user asks for new behavior with the attribute.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: sched: make default fifo qdiscs appear in the dump Jiri Kosina <jikos@kernel.org> - 2016-10-21 10:50 +0200
  Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump Eric Dumazet <eric.dumazet@gmail.com> - 2016-10-21 13:40 +0200
    Re: [PATCH] net: sched: make default fifo qdiscs appear in the  dump Jiri Kosina <jikos@kernel.org> - 2016-10-21 15:00 +0200
      Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump Eric Dumazet <eric.dumazet@gmail.com> - 2016-10-21 15:20 +0200
        Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump David Miller <davem@davemloft.net> - 2016-10-21 17:10 +0200
          Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump Eric Dumazet <eric.dumazet@gmail.com> - 2016-10-21 17:50 +0200
      Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump David Miller <davem@davemloft.net> - 2016-10-21 17:00 +0200
    Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump David Miller <davem@davemloft.net> - 2016-10-21 17:00 +0200
      Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump Eric Dumazet <eric.dumazet@gmail.com> - 2016-10-21 17:30 +0200

csiph-web