Re: FRV-setup: Clarification for "source code clean-up"?

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: FRV-setup: Clarification for "source code clean-up"?
Date	2016-10-21 11:30 +0200
Message-ID	<suEjh-3AW-85@gated-at.bofh.it> (permalink)
References	<suAfD-16j-9@gated-at.bofh.it> <suApj-1a2-3@gated-at.bofh.it> <suCr8-2ns-11@gated-at.bofh.it> <suCUa-2xD-25@gated-at.bofh.it> <suE9B-3xe-69@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 21, 2016 at 11:11:54AM +0200, SF Markus Elfring wrote:
> > It's all about ratios...  Each clean up patch has chance of introducing
> > a bug.
> 
> Each update suggestion contains a possibility for mistakes.
> 

Yes.  But bug fix patches make up for it by fixing stuff.

> 
> > If you only send clean up patches then you only introduce bugs.
> 
> I find such a conclusion questionable with the wording "only".
> 

How are you going to fix bugs if you only send clean ups?

> 
> > We really don't want people sending patches if they introduce more bugs
> > than they fix.
> 
> How do you think about to discuss corresponding software development
> statistics in more detail?

I think normal developers should fix 10 bugs or add a few features for
every regression they introduce.  I introduced a regression just last
week, so that's a normal part of life, but I was at least *trying* to
fix a bug when I did it.

regards,
dan carpenter

Thread

[PATCH 0/6] FRV-setup: Fine-tuning for six function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 07:10 +0200
  [PATCH 2/6] FRV-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 07:10 +0200
  [PATCH 3/6] FRV-setup: Add some spaces for better code readability SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 07:10 +0200
  [PATCH 5/6] FRV-setup: Fix indentation in two lines SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 07:20 +0200
    Re: [PATCH 5/6] FRV-setup: Fix indentation in two lines Jiri Kosina <jikos@kernel.org> - 2016-10-21 09:30 +0200
      Re: [PATCH 5/6] FRV-setup: Fix indentation in two lines Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-21 10:00 +0200
        Re: FRV-setup: Clarification for "source code clean-up"? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 11:20 +0200
          Re: FRV-setup: Clarification for "source code clean-up"? Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-21 11:30 +0200
            Re: FRV-setup: Clarification for "source code clean-up"? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 12:00 +0200
              Re: FRV-setup: Clarification for "source code clean-up"? Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-21 12:30 +0200
              Re: FRV-setup: Clarification for "source code clean-up"? Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-21 12:30 +0200
                Re: FRV-setup: Clarification for "source code clean-up"? Julia Lawall <julia.lawall@lip6.fr> - 2016-10-21 13:10 +0200
                Re: Improving software around DMA API usage? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 13:40 +0200
  [PATCH 6/6] FRV-setup: Move statements for "case" to separate lines SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-21 07:20 +0200

csiph-web