Re: [PATCH 05/10] gpio: i2cs: Juniper I2CS to GPIO pin mapping driver

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/10] gpio: i2cs: Juniper I2CS to GPIO pin mapping driver
Date	2016-10-21 10:50 +0200
Message-ID	<suDGx-37e-3@gated-at.bofh.it> (permalink)
References	<spFfX-2lv-9@gated-at.bofh.it> <spFfX-2lv-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 7, 2016 at 5:21 PM, Pantelis Antoniou
<pantelis.antoniou@konsulko.com> wrote:

> From: Guenter Roeck <groeck@juniper.net>
>
> This driver maps I2C slave register bits to GPIO pins. Registers
> are supposed to be 8 bit wide. Interrupt support is optional.
>
> The driver is implemented as client of the I2CS MFD driver.
>
> Signed-off-by: Georgi Vlaev <gvlaev@juniper.net>
> Signed-off-by: Guenter Roeck <groeck@juniper.net>
> Signed-off-by: JawaharBalaji Thirumalaisamy <jawaharb@juniper.net>
> [Ported from Juniper kernel]
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>

This driver again has the same review comments as the two first
ones, GPIOLIB_IRQCHIP etc. Revise accordingly and repost
and I will look at it again.

(Interestingly this one uses BIT() properly.)

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 05/10] gpio: i2cs: Juniper I2CS to GPIO pin mapping driver Linus Walleij <linus.walleij@linaro.org> - 2016-10-21 10:50 +0200

csiph-web