Re: exynos-drm: display manager fails to start without IOMMU problem

From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: exynos-drm: display manager fails to start without IOMMU problem
Date	2016-10-20 01:00 +0200
Message-ID	<su806-7Cg-7@gated-at.bofh.it> (permalink)
References	(6 earlier) <s6Eu6-6Tr-11@gated-at.bofh.it> <srAYx-2VU-3@gated-at.bofh.it> <srAYx-2VU-1@gated-at.bofh.it> <stm53-7V9-5@gated-at.bofh.it> <su1UC-3KZ-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/19/2016 10:23 AM, Tobias Jakobi wrote:
> Hello Shuah,
> 
> just a short note that more misleading comments about default allocation
> flags can be found in libdrm.
> 
> https://cgit.freedesktop.org/mesa/drm/tree/exynos/exynos_drm.c
> 
> See e.g. the comment for exynos_bo_create().
> 
> In my opinion, the whole approach to _set_ a bit to get non-contigious
> memory is messed up. It would make more sense to me to set a bit to
> request an additional property (here "being contiguous") of the memory.
> 
> Anyway, clearing up this situation is highly appreciated!
> 
> More comments below.
> 
> With best wishes,
> Tobias
> 

Hi Tobias,

Thanks for the note. Yes the comments are confusing. It seems like
some old assumptions are persisting. I will fix these as well.

-- Shuah

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

exynos-drm: display manager fails to start without IOMMU problem Shuah Khan <shuahkh@osg.samsung.com> - 2016-10-17 21:50 +0200
  Re: exynos-drm: display manager fails to start without IOMMU problem Tobias Jakobi <tjakobi@math.uni-bielefeld.de> - 2016-10-19 18:30 +0200
    Re: exynos-drm: display manager fails to start without IOMMU problem Shuah Khan <shuahkh@osg.samsung.com> - 2016-10-20 01:00 +0200

csiph-web