Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1504246
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] perf, tools, list: Support matching by topic |
| Date | 2016-10-19 20:40 +0200 |
| Message-ID | <su3Wr-53C-69@gated-at.bofh.it> (permalink) |
| References | <su3jH-4wR-1@gated-at.bofh.it> <su3jI-4wR-17@gated-at.bofh.it> <su3D3-4Wo-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> > index 1095a6dada66..c00b0eb343c0 100644
> > --- a/tools/perf/builtin-list.c
> > +++ b/tools/perf/builtin-list.c
> > @@ -67,9 +67,11 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused)
> > print_symbol_events(NULL, PERF_TYPE_SOFTWARE,
> > event_symbols_sw, PERF_COUNT_SW_MAX, raw_dump);
> > else if (strcmp(argv[i], "cache") == 0 ||
> > - strcmp(argv[i], "hwcache") == 0)
> > + strcmp(argv[i], "hwcache") == 0) {
>
> This is changing existing behaviour, please remove it. A separate patch
> could either make it show both hwcache events and vendor cache events,
That's what the patch does: "show both hwcache and vendor cache events"
which is a reasonable default.
I can split it into a separate patch if makes you feel better.
>
> > print_hwcache_events(NULL, raw_dump);
> > - else if (strcmp(argv[i], "pmu") == 0)
> > + print_pmu_events(argv[i], raw_dump, !desc_flag,
> > + long_desc_flag, true);
> > + } else if (strcmp(argv[i], "pmu") == 0)
> > print_pmu_events(NULL, raw_dump, !desc_flag,
> > long_desc_flag, false);
>
> What is this here?
Only adding a } but diff displays it in a weird way.
-Andi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] perf, tools, list: Make vendor event matching case insensitive Andi Kleen <andi@firstfloor.org> - 2016-10-19 20:00 +0200
[PATCH 2/2] perf, tools, list: Support matching by topic Andi Kleen <andi@firstfloor.org> - 2016-10-19 20:00 +0200
Re: [PATCH 2/2] perf, tools, list: Support matching by topic Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-19 20:20 +0200
Re: [PATCH 2/2] perf, tools, list: Support matching by topic Andi Kleen <andi@firstfloor.org> - 2016-10-19 20:40 +0200
Re: [PATCH 1/2] perf, tools, list: Make vendor event matching case insensitive Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-19 20:20 +0200
[tip:perf/core] perf list: Make vendor event matching case insensitive tip-bot for Andi Kleen <tipbot@zytor.com> - 2016-10-24 21:20 +0200
csiph-web