Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1504142

Re: [PATCH v2] ARC: Adjust cpuinfo for non-continuous cpu ids

From Vineet Gupta <Vineet.Gupta1@synopsys.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] ARC: Adjust cpuinfo for non-continuous cpu ids
Date 2016-10-19 19:10 +0200
Message-ID <su2xj-4eW-1@gated-at.bofh.it> (permalink)
References <su2xj-4eW-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 10/19/2016 04:25 AM, Noam Camus wrote:
> From: Noam Camus <noamc@ezchip.com>
>
> num_possible_cpus() returns how many CPUs may be present on system.
> However we want the highest possible CPU number.
> This may be differ in a sparsed possible CPUs map.
> Such map achived by OF for plat-eznps.
>
> For example if we have:
> possible cpus mask 0,3
>
> Then:
> num_possible_cpus() is equal 2
> 	while
> nr_cpu_ids is equal 4.
>
> Only for value 4 c_start() will provide correct cpuinfo at procfs.

This is much much better. Applied to for-curr !

Thx,
-Vineet

>
> Signed-off-by: Noam Camus <noamc@ezchip.com>
> ---
>  arch/arc/kernel/setup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index 64907de..bd2e3a4 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -512,7 +512,7 @@ static void *c_start(struct seq_file *m, loff_t *pos)
>  	 * way to pass it w/o having to kmalloc/free a 2 byte string.
>  	 * Encode cpu-id as 0xFFcccc, which is decoded by show routine.
>  	 */
> -	return *pos < num_possible_cpus() ? cpu_to_ptr(*pos) : NULL;
> +	return *pos < nr_cpu_ids ? cpu_to_ptr(*pos) : NULL;
>  }
>  
>  static void *c_next(struct seq_file *m, void *v, loff_t *pos)

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v2] ARC: Adjust cpuinfo for non-continuous cpu ids Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-19 19:10 +0200

csiph-web