Re: [PATCH] proc: fix NULL dereference when reading /proc/<pid>/auxv

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] proc: fix NULL dereference when reading /proc/<pid>/auxv
Date	2016-10-19 18:50 +0200
Message-ID	<su2dZ-3Sv-47@gated-at.bofh.it> (permalink)
References	<su02u-2rf-51@gated-at.bofh.it> <su1KV-3Hg-11@gated-at.bofh.it> <su1KV-3Hg-13@gated-at.bofh.it> <su1KV-3Hg-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/19, Michal Hocko wrote:
>
> On Wed 19-10-16 18:12:08, Oleg Nesterov wrote:
> > On 10/19, Michal Hocko wrote:
> > >
> > > Why would we even want to open that file if there is no mm struct?
> >
> > Agreed this is strange, but I am not sure we can change this old
> > behaviour. Say, cat /proc/$pid-of-kthread/mem doesn't fail, it shows
> > the "empty mm".
>
> What kind of application would break?

I have no idea, probably nobody will ever notice this change, just
I am always nervous when it comes to user-visible changes.

But why do we want this change? Not that I am going to argue if you
submit a patch, but personally I see no real point.

Oleg.

Thread

Re: [PATCH] proc: fix NULL dereference when reading /proc/<pid>/auxv Michal Hocko <mhocko@kernel.org> - 2016-10-19 18:20 +0200
  Re: [PATCH] proc: fix NULL dereference when reading         /proc/<pid>/auxv Oleg Nesterov <oleg@redhat.com> - 2016-10-19 18:50 +0200
    Re: [PATCH] proc: fix NULL dereference when reading /proc/<pid>/auxv Michal Hocko <mhocko@kernel.org> - 2016-10-19 19:10 +0200

csiph-web