Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1503718
| From | Wanpeng Li <kernellwp@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() |
| Date | 2016-10-19 16:40 +0200 |
| Message-ID | <su0cb-2v4-67@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <stcIp-1IH-7@gated-at.bofh.it> <stdbr-2aY-3@gated-at.bofh.it> <stq8G-2CX-13@gated-at.bofh.it> <stZSN-2nd-23@gated-at.bofh.it> <su0cb-2v4-69@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Cc Radim,
2016-10-19 22:10 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>
>
> On 19/10/2016 16:01, Wanpeng Li wrote:
>> 2016-10-18 8:01 GMT+08:00 Wanpeng Li <kernellwp@gmail.com>:
>>> 2016-10-17 18:08 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>>> [...]
>>>>>> Something like the below avoids all that. Paravirt will still need fixing.
>>>>>
>>>>> kvm_guest_apic_eoi_write
>>>>> -> native_apic_msr_write
>>>>
>>>> kvm_guest_apic_eoi_write can use native_apic_msr_eoi_write too:
>>>>
>>>> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
>>>> index f5aaf6c83222..9769d76a62c4 100644
>>>> --- a/arch/x86/include/asm/apic.h
>>>> +++ b/arch/x86/include/asm/apic.h
>>>> @@ -174,7 +174,7 @@ static inline void disable_local_APIC(void) { }
>>>> static inline void lapic_update_tsc_freq(void) { }
>>>> #endif /* !CONFIG_X86_LOCAL_APIC */
>>>>
>>>> -#ifdef CONFIG_X86_X2APIC
>>>> +#if defined CONFIG_X86_X2APIC || defined CONFIG_KVM_GUEST
>>>
>>> If CONFIG_X86_X2APIC is undefined and CONFIG_KVM_GUEST is defined,
>>> there are undefined reference warning for x2apic_mode and check_x2apic
>>> etc since they are extern variables and just define under
>>> CONFIG_X86_X2APIC.
>>
This results in undefined reference warning.
>>
>>>
>>> If -cpu host,-x2apic we should go through mmio when writes xapic EOI.
>>
>> Any ideas? :)
>
> Make apic_set_eoi_write return the old pointer?
Could you elaborate? :)
Regards,
Wanpeng Li
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Wanpeng Li <kernellwp@gmail.com> - 2016-10-14 03:50 +0200
[tip:x86/urgent] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() tip-bot for Wanpeng Li <tipbot@zytor.com> - 2016-10-14 14:30 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Peter Zijlstra <peterz@infradead.org> - 2016-10-16 15:40 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Wanpeng Li <kernellwp@gmail.com> - 2016-10-17 06:30 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Peter Zijlstra <peterz@infradead.org> - 2016-10-17 10:30 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Wanpeng Li <kernellwp@gmail.com> - 2016-10-17 11:50 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Paolo Bonzini <pbonzini@redhat.com> - 2016-10-17 12:20 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Wanpeng Li <kernellwp@gmail.com> - 2016-10-17 12:30 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Wanpeng Li <kernellwp@gmail.com> - 2016-10-18 02:10 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Wanpeng Li <kernellwp@gmail.com> - 2016-10-19 16:20 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Wanpeng Li <kernellwp@gmail.com> - 2016-10-19 16:40 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Paolo Bonzini <pbonzini@redhat.com> - 2016-10-24 16:40 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Wanpeng Li <kernellwp@gmail.com> - 2016-10-25 05:00 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Paolo Bonzini <pbonzini@redhat.com> - 2016-10-19 18:40 +0200
Re: [PATCH] x86/smp: Add irq_enter/exit() in smp_reschedule_interrupt() Wanpeng Li <kernellwp@gmail.com> - 2016-10-17 14:20 +0200
csiph-web