Re: [PATCH] dmaengine: ioatdma: loop for number elements in array chanerr_str

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dmaengine: ioatdma: loop for number elements in array chanerr_str
Date	2016-10-19 16:40 +0200
Message-ID	<su0c9-2v4-5@gated-at.bofh.it> (permalink)
References	<ssSJH-5O2-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Oct 16, 2016 at 01:25:47PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Just iterate over the number of elements in array chanerr_str rather
> than for all 32 bits.  This removes the need for a NULL chanerr_str[i]
> check which could possibly overrun if the upper bits (28..31) of
> chanerr are set and 27th bit in chanerr is zero. This simplifies the
> code by removing an if statement and a break.

Applied, thanks

-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] dmaengine: ioatdma: loop for number elements in array chanerr_str Colin King <colin.king@canonical.com> - 2016-10-16 14:30 +0200
  Re: [PATCH] dmaengine: ioatdma: loop for number elements in array  chanerr_str Vinod Koul <vinod.koul@intel.com> - 2016-10-19 16:40 +0200

csiph-web