Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503663

Re: [Intel-wired-lan] [PATCH] igb: add missing fields to TXDCTL-register

Show all headers | View raw

On Wed, 19 Oct 2016 14:37:59 +0200
Henrik Austad <henrik@austad.us> wrote:

> The current list of E1000_TXDCTL-registers is incomplete. This adds
> the missing parts for the Transmit Descriptor Control (TXDCTL)
> register.
> 
> The rest of these values (threshold for descriptor read/write) for
> TXDCTL seems to be defined in igb/igb.h, not sure why this is split
> though.

Hi Henrik, thanks for helping with our code.

While totally correct, having defines added to the kernel that are not
being used anywhere in the code isn't really very useful.  Often the
upstream maintainers/reviewers will reject a patch like this that just
adds to a .h file, because there are no actual users of the defines.

If the transmit or ethtool code were to use these (via the same patch)
or something like that, then the patch would be more likely to be
accepted.

Jesse

PS In the future no need to copy linux-kernel for patches going to our
submaintainer list.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [Intel-wired-lan] [PATCH] igb: add missing fields to  TXDCTL-register Jesse Brandeburg <jesse.brandeburg@intel.com> - 2016-10-19 16:30 +0200
  Re: [Intel-wired-lan] [PATCH] igb: add missing fields to  TXDCTL-register Henrik Austad <henrik@austad.us> - 2016-10-19 17:10 +0200

csiph-web