Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1502685
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Vivek Gautam <vivek.gautam@codeaurora.org> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/7] phy: qcom-ufs: Use devm sibling of kstrdup for regulator names |
| Date | Tue, 18 Oct 2016 06:50:01 +0200 |
| Message-ID | <stuvD-5o7-5@gated-at.bofh.it> (permalink) |
| References | <stuvD-5o7-3@gated-at.bofh.it> |
| X-Original-To | kishon@ti.com, jejb@linux.vnet.ibm.com, vinholikatti@gmail.com, martin.petersen@oracle.com, linux-kernel@vger.kernel.org |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1476766167; bh=1nYLrEtmFTs6ekkKtI7Vdjri+MlGDTua99WBOKYr3UQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oIT/EZNCzwuCfnQV/HciDFERmetBfRKx91Clmdst3JLWNZunXn20kKnRxiLBNI4hl Qb7Z8qUvS1uG/1N5l9VT6eji6hD6bLBVlf6qcoqAofii4+q2UXR8gOmtCFKpOltFsD iffZSTVJM1IwZo+bnH9G7nq4Db3fs85X1Znz749Q= |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1476766166; bh=1nYLrEtmFTs6ekkKtI7Vdjri+MlGDTua99WBOKYr3UQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SLe+E6sc6RimEKAn2YEGoZ42ghf+NEDDHCP8oDyqjDqtsiiGPs0eXI/j0sCa6HKX4 QrlT6s6UkJJ0ZPhwvgW9yjXWICv6RCCVg22ZYKCMQuXYHbLJ7o0ohaAQcb/fI+wDuK 9Iz1/gPlB0TWhj+NIRGb+Ujwc32iazBm+hKL0MFw= |
| Dmarc-Filter | OpenDMARC Filter v1.3.1 smtp.codeaurora.org 42BC861814 |
| Authentication-Results | pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org |
| Authentication-Results | pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=vivek.gautam@codeaurora.org |
| X-Mailer | git-send-email 1.9.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 35 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | subhashj@codeaurora.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Vivek Gautam <vivek.gautam@codeaurora.org> |
| X-Original-Date | Tue, 18 Oct 2016 10:19:01 +0530 |
| X-Original-Message-ID | <1476766145-27583-4-git-send-email-vivek.gautam@codeaurora.org> |
| X-Original-References | <1476766145-27583-1-git-send-email-vivek.gautam@codeaurora.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1502685 |
Show key headers only | View raw
This helps us in avoiding any requirement for kfree() operation
to be called exclusively over the allocated string pointer.
Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
---
drivers/phy/phy-qcom-ufs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index 805c91d..f639a7c 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -262,7 +262,7 @@ static int __ufs_qcom_phy_init_vreg(struct phy *phy,
char prop_name[MAX_PROP_NAME];
- vreg->name = kstrdup(name, GFP_KERNEL);
+ vreg->name = devm_kstrdup(dev, name, GFP_KERNEL);
if (!vreg->name) {
err = -ENOMEM;
goto out;
@@ -650,9 +650,6 @@ int ufs_qcom_phy_remove(struct phy *generic_phy,
{
phy_power_off(generic_phy);
- kfree(ufs_qcom_phy->vdda_pll.name);
- kfree(ufs_qcom_phy->vdda_phy.name);
-
return 0;
}
EXPORT_SYMBOL_GPL(ufs_qcom_phy_remove);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 06:50 +0200 [PATCH 3/7] phy: qcom-ufs: Use devm sibling of kstrdup for regulator names Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 06:50 +0200 [PATCH 7/7] ufs-qcom: phy/hcd: Refactoring phy clock handling Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 07:00 +0200 [PATCH 4/7] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers. Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 07:00 +0200 [PATCH 5/7] phy: qcom-ufs: Cleanup clock and regulator initialization Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 07:00 +0200 [PATCH 6/7] phy: qcom-ufs-qmp-xx: Move clock and regulator init out of phy init Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 07:00 +0200 [PATCH 1/7] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 07:00 +0200
csiph-web