Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1502683
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Vivek Gautam <vivek.gautam@codeaurora.org> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/7] phy: qcom-ufs: Remove unnecessary BUG_ON |
| Date | Tue, 18 Oct 2016 06:50:01 +0200 |
| Message-ID | <stuvD-5o7-1@gated-at.bofh.it> (permalink) |
| References | <stuvD-5o7-3@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1476766162; bh=H6zvccWP8FmYT8fatdA7eZdBsyVYlFZjzfLT67Cl/WA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fRpRE/9zSneNZ/KB7gXOcoXRQeJXVBSL9NNjoHcWFxqH/Dvn2vqn2b+p/qU8pu0bu e5JUOPIcF2dNhEE9SV5ki0BYkqwRwKhc8JHwhcr1L4WybWgmhB3xsHcy0Cq+Ya/M7s UUBBz7HQG90wJ7i2Vjov5cz8nYepA24/bwBGSSjI= |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1476766162; bh=H6zvccWP8FmYT8fatdA7eZdBsyVYlFZjzfLT67Cl/WA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fRpRE/9zSneNZ/KB7gXOcoXRQeJXVBSL9NNjoHcWFxqH/Dvn2vqn2b+p/qU8pu0bu e5JUOPIcF2dNhEE9SV5ki0BYkqwRwKhc8JHwhcr1L4WybWgmhB3xsHcy0Cq+Ya/M7s UUBBz7HQG90wJ7i2Vjov5cz8nYepA24/bwBGSSjI= |
| Dmarc-Filter | OpenDMARC Filter v1.3.1 smtp.codeaurora.org 7A03D61814 |
| Authentication-Results | pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org |
| Authentication-Results | pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=vivek.gautam@codeaurora.org |
| X-Mailer | git-send-email 1.9.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 26 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | subhashj@codeaurora.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Vivek Gautam <vivek.gautam@codeaurora.org> |
| X-Original-Date | Tue, 18 Oct 2016 10:19:00 +0530 |
| X-Original-Message-ID | <1476766145-27583-3-git-send-email-vivek.gautam@codeaurora.org> |
| X-Original-References | <1476766145-27583-1-git-send-email-vivek.gautam@codeaurora.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1502683 |
Show key headers only | View raw
BUG_ON() are not preferred in the driver, plus the variable
on which BUG_ON is asserted is already checked in the code
before passing.
Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
---
drivers/phy/phy-qcom-ufs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index 183ec04..805c91d 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -335,8 +335,6 @@ int ufs_qcom_phy_cfg_vreg(struct phy *phy,
struct ufs_qcom_phy *ufs_qcom_phy = get_ufs_qcom_phy(phy);
struct device *dev = ufs_qcom_phy->dev;
- BUG_ON(!vreg);
-
if (regulator_count_voltages(reg) > 0) {
min_uV = on ? vreg->min_uV : 0;
ret = regulator_set_voltage(reg, min_uV, vreg->max_uV);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 2/7] phy: qcom-ufs: Remove unnecessary BUG_ON Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-18 06:50 +0200
csiph-web